Remove FB copyright notices from iOS template #27725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
alloy
commented
Jan 9, 2020
| @@ -557,7 +556,7 @@ | |||
| "-ObjC", | |||
| "-lc++", | |||
| ); | |||
| PRODUCT_BUNDLE_IDENTIFIER = "com.facebook.REACT.HelloWorld-tvOS"; | |||
| PRODUCT_BUNDLE_IDENTIFIER = "org.reactjs.native.example.HelloWorld-tvOS"; | |||
There was a problem hiding this comment.
These PRODUCT_BUNDLE_IDENTIFIER changes are to bring the tvOS products in line with the iOS one.
|
@TheSavior, the |
facebook-github-bot
approved these changes
Jan 10, 2020
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@zertosh Just a heads-up, but those links don’t work for people like me that have no FB account. |
|
Yeah, he knows. They were internal fb links for config files I will need to change in other parts of our monorepo :-) |
|
Ah ok, I see 👍 |
|
This is failing our internal CI with this log: I believe @hramos has worked on upgrading the ios simulator internally and may have context on this. |
|
@rickhanlonii's 5cd0c8a should fix the simulator issue that @TheSavior raised. I also have https://our.internmc.facebook.com/intern/diff/D18849584/ (mirrored to GitHub in https://github.com/hramos/react-native/tree/export-D18849584) in flight which should bring tests to Xcode 11.2.1, with Xcode 11.3 coming soon after. |
|
This pull request was successfully merged by @alloy in 9c3fa57. When will my fix make it into a release? | Upcoming Releases |
|
It landed! |
alloy
added a commit
to alloy/react-native
that referenced
this pull request
Feb 5, 2020
Summary: Files that are to be part of the user’s project shouldn’t have FB copyright notices. There’s [one notice left](https://github.com/facebook/react-native/blob/66601e755fcad10698e61d20878d52194ad0e90c/template/android/app/src/debug/java/com/helloworld/ReactNativeFlipper.java#L2) in the `android` template, which is in a file that doesn’t seem to be intended to be changed by the user and so that seems fine to me. [iOS] [Removed] - Remove copyright notices from iOS application template Pull Request resolved: facebook#27725 Test Plan: ```bash npx react-native init TestTemplateUpdates --template ~/Code/ReactNative/react-native cd ios xcodebuild -workspace TestTemplateUpdates.xcworkspace \ -scheme TestTemplateUpdates \ -destination 'platform=iOS Simulator,OS=latest,name=iPhone 8' build […] ** BUILD SUCCEEDED ** ``` Differential Revision: D19343386 Pulled By: TheSavior fbshipit-source-id: a78be5e5d2fdc2477adedb51d6bb3ff19845b75f
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: Files that are to be part of the user’s project shouldn’t have FB copyright notices. There’s [one notice left](https://github.com/facebook/react-native/blob/66601e755fcad10698e61d20878d52194ad0e90c/template/android/app/src/debug/java/com/helloworld/ReactNativeFlipper.java#L2) in the `android` template, which is in a file that doesn’t seem to be intended to be changed by the user and so that seems fine to me. ## Changelog [iOS] [Removed] - Remove copyright notices from iOS application template Pull Request resolved: facebook#27725 Test Plan: ```bash npx react-native init TestTemplateUpdates --template ~/Code/ReactNative/react-native cd ios xcodebuild -workspace TestTemplateUpdates.xcworkspace \ -scheme TestTemplateUpdates \ -destination 'platform=iOS Simulator,OS=latest,name=iPhone 8' build […] ** BUILD SUCCEEDED ** ``` Differential Revision: D19343386 Pulled By: TheSavior fbshipit-source-id: a78be5e5d2fdc2477adedb51d6bb3ff19845b75f
4 tasks
alloy
added a commit
to microsoft/react-native-macos
that referenced
this pull request
Apr 2, 2020
Equal to upstream iOS change facebook#27725
tom-un
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Apr 2, 2020
* [macos-init] Build on publish * [generate-macos] Cleanup copy-paste leftover * [generator-macos] Remove FB copyright notices Equal to upstream iOS change facebook#27725 * [generator-macos] Name app product without `-macOS` suffix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Files that are to be part of the user’s project shouldn’t have FB copyright notices.
There’s one notice left in the
androidtemplate, which is in a file that doesn’t seem to be intended to be changed by the user and so that seems fine to me.Changelog
[iOS] [Removed] - Remove copyright notices from iOS application template
Test Plan