Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid race conditions when setting RCTNetworkTask status #28962

Closed
wants to merge 2 commits into from
Closed

Avoid race conditions when setting RCTNetworkTask status #28962

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8529fd
Avoid race conditions when setting RCTNetworkTask status
petertravelchime May 23, 2020
0606663
Merge branch 'master' into peter-network-task
pxpeterxu Jul 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Libraries/Network/RCTNetworkTask.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,18 @@ - (void)start
id token = [_handler sendRequest:_request withDelegate:self];
if ([self validateRequestToken:token]) {
_selfReference = self;
_status = RCTNetworkTaskInProgress;

// It's possible that, between the start of this function and now that:
// 1. This thread has yielded
// 2. Another thread had already processed sendRequest:_request, and
// set status to RCTNetworkTaskFinished by calling didCompleteWithError
// 3. This thread continues executing
//
// As a result, we first check to make sure this network request hadn't
// already finished before setting the status to "In progress"
if (_status == RCTNetworkTaskPending) {
_status = RCTNetworkTaskInProgress;
}
}
}
}
Expand Down