okhttp version 3.12.12

[halaei]

Summary

This updates okhttp to the newest compatible version with a couple of fixes and improvements. See https://github.com/square/okhttp/commits/okhttp_3.12.x

Changelog

[Android] [Changed] - Update Okhttp to version 3.12.12

Test Plan

Current tests should pass.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,004,557	-204,276
android	hermes	armeabi-v7a	6,668,155	-189,854
android	hermes	x86	7,424,850	-218,615
android	hermes	x86_64	7,315,761	-218,652
android	jsc	arm64-v8a	9,164,310	-203,244
android	jsc	armeabi-v7a	8,820,038	-188,812
android	jsc	x86	9,012,712	-217,558
android	jsc	x86_64	9,589,785	-217,629

Base commit: 871e14f

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 871e14f

[dulmandakh]

please bump okhttp in Buck too, so that CI can use the change

[dulmandakh]

@mdvacca please review and merge

[dulmandakh]

@mdvacca @fkgozali it looks like this PR would fix many crashes according to OkHTTP changelog, please merge it as soon as possible https://square.github.io/okhttp/changelog_3x/#version-3126

[mdvacca]

LGTM

[facebook-github-bot]

@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @halaei in 0f6fcb2.

^{When will my fix make it into a release? | Upcoming Releases}

[jgreen210]

(I'm a RN user trying to resolve an okhttp/okhttp-urlconnection version conflict between react-native (which wants a 3.x version) and another library (which wants a 4.x version). I need to decide whether to force use of 3.x or 4.x in our app, with both choices potentially breaking something, based on semver.)

So, is someone able to elaborate on why the "newest compatible version" of okhttp etc. isn't a 4.x version?

I've checked the open github issues mentioning "okhttp", plus the recent closed ones, and while there is #27282, it doesn't explain what problems exist with 4.x.

[halaei]

@jgreen210 I am not sure, maybe okhttp 4.x doesn't work on Android < 5.0? React Native supports Android >=4.1.
https://github.com/square/okhttp#requirements

[mikehardy]

@jgreen210 - @halaei is exactly right. react-native minSdkVersion is API16 so they must stay on the 3.12.x okhttp branch