Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for --sourcemap-output path containing spaces in Xcode projects #30981

Closed
wants to merge 2 commits into from
Closed

Fix support for --sourcemap-output path containing spaces in Xcode projects #30981

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c90343
Fix support for SOURCEMAP_FILE containing spaces
nickdowell Feb 11, 2021
9ad6e61
Apply suggestions from code review
nickdowell Feb 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions scripts/react-native-xcode.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ fi

BUNDLE_FILE="$CONFIGURATION_BUILD_DIR/main.jsbundle"

EXTRA_ARGS=
EXTRA_ARGS=()

case "$PLATFORM_NAME" in
"macosx")
Expand All @@ -160,12 +160,12 @@ if [[ $EMIT_SOURCEMAP == true ]]; then
else
PACKAGER_SOURCEMAP_FILE="$SOURCEMAP_FILE"
fi
EXTRA_ARGS="$EXTRA_ARGS --sourcemap-output $PACKAGER_SOURCEMAP_FILE"
EXTRA_ARGS+=("--sourcemap-output" "$PACKAGER_SOURCEMAP_FILE")
fi

# Hermes doesn't require JS minification.
if [[ $USE_HERMES == true && $DEV == false ]]; then
EXTRA_ARGS="$EXTRA_ARGS --minify false"
EXTRA_ARGS+=("--minify" "false")
fi

"$NODE_BINARY" $NODE_ARGS "$CLI_PATH" $BUNDLE_COMMAND \
Expand All @@ -176,7 +176,7 @@ fi
--reset-cache \
--bundle-output "$BUNDLE_FILE" \
--assets-dest "$DEST" \
$EXTRA_ARGS \
"${EXTRA_ARGS[@]}" \
$EXTRA_PACKAGER_ARGS

if [[ $USE_HERMES != true ]]; then
Expand Down