Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message formatting #31338

Closed
wants to merge 1 commit into from
Closed

Conversation

BenLorantfy
Copy link
Contributor

@BenLorantfy BenLorantfy commented Apr 11, 2021

Summary

This error message doesn't format correctly when outputted to the terminal. It seems the 2nd line is missing

Changelog

[iOS] [Fixed] - bug with error message formatting when bundle is missing

Test Plan

Before:
wHHXtKq

After:
6nIjRHc

@facebook-github-bot
Copy link
Contributor

Hi @BenLorantfy!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 11, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@analysis-bot
Copy link

analysis-bot commented Apr 11, 2021

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: c37f719
Branch: main

@charlesbdudley charlesbdudley self-assigned this Sep 13, 2021
@facebook-github-bot
Copy link
Contributor

@charlesbdudley has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@charlesbdudley
Copy link
Contributor

Hi @BenLorantfy Could you please rebase to get these circleci checks green and I'll get this merged?

This error message doesn't format correctly when outputted to the terminal.  It seems the 2nd line is missing
@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,799,665 -2,828
android hermes armeabi-v7a 7,194,370 -892
android hermes x86 8,110,306 -2,191
android hermes x86_64 8,090,015 -2,022
android jsc arm64-v8a 9,696,735 +0
android jsc armeabi-v7a 8,451,995 +0
android jsc x86 9,647,485 +0
android jsc x86_64 10,245,252 +0

Base commit: c37f719
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @BenLorantfy in f501979.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Needs: Author Feedback Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants