-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error message formatting #31338
Fix error message formatting #31338
Conversation
Hi @BenLorantfy! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Base commit: c37f719 |
@charlesbdudley has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Hi @BenLorantfy Could you please rebase to get these circleci checks green and I'll get this merged? |
This error message doesn't format correctly when outputted to the terminal. It seems the 2nd line is missing
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: c37f719 |
This pull request was successfully merged by @BenLorantfy in f501979. When will my fix make it into a release? | Upcoming Releases |
Summary
This error message doesn't format correctly when outputted to the terminal. It seems the 2nd line is missing
Changelog
[iOS] [Fixed] - bug with error message formatting when bundle is missing
Test Plan
Before:
After: