-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note for reloading app #324
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
@@ -25,7 +25,7 @@ In the newly created folder `AwesomeProject/` | |||
|
|||
- Open `AwesomeProject.xcodeproj` and hit run in Xcode | |||
- Open `index.ios.js` in your text editor of choice and edit some lines | |||
- Hit cmd+R ([twice](http://openradar.appspot.com/19613391)) in your iOS simulator to reload the app and see your change! | |||
- Hit CMD+R ([twice](http://openradar.appspot.com/19613391)) in your iOS simulator to reload the app and see your change(Make sure `Connect Hardware Keyboard` of `Hardware` menu in simulator checked)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space between change
and (Make
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LinusU Sorry, I forgot to add a space.
@imWildCat You don't need to open another PQ to fix this, simple push the same branch and the new commits will show up here. |
@LinusU Oh sorry, I didn't know that. Thank you very much for your suggestion! |
But how to reload on device? Maybe also a good idea mention that in the doc? |
* Replace UtilsRN.option_map by Belt.Option.map This PR remove `UtilsRN.option_map` and replace all usage by `Belt.Option.map`. While I was on this change, I use `->` to send props to map function. Feel more natural imo. When it made sense, I also move `fromOption` at the end using `->` too. Also, I remplaced som `x => switch(x) {` by `fun`. * Remove unused << * Remove UtilsRN.objAssign2
In #120 or #306, the posters including me didn’t know it was necessary to check
“Connect Hardware Keyboard”.