Fix a broken input for the Korean alphabet in TextInput

[kmsbernard]

Summary

Fix #32503

Updating the attributed text in TextView/TextField while inputting Korean language will break input mechanism of the Korean alphabet. This results unexpected text input.

This PR supersedes the previous fixes: #19809, #22546

Changelog

[iOS] [Fixed] - Fix a broken input for the Korean alphabet in TextInput

Test Plan

RPReplay_Final1635916183_c.mov

[facebook-github-bot]

Hi @bernard-kms!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[pull-bot]

PR build artifact for c679dab is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,290,542	-186,577
android	hermes	armeabi-v7a	7,854,574	+78,057
android	hermes	x86	8,657,623	-288,371
android	hermes	x86_64	8,616,752	-273,391
android	jsc	arm64-v8a	9,791,779	-154
android	jsc	armeabi-v7a	8,752,609	+74
android	jsc	x86	9,740,711	-38
android	jsc	x86_64	10,341,567	-84

Base commit: 8ace78c
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 8ace78c
Branch: main

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[lunaleaps]

Could you explain why this is redundant and safe to remove?

[kmsbernard]

Root cause of this issue is updating attributedText via -setAttributedText: of RCTBaseTextInputView.
In this removed block, it attempts to avoid calling the method by comparing two attributed text with bare strings. But it should be handled by -textOf:quals: which already handles some other special cases such as Chinese and Japanese.
I added detection for Korean to safely fallbacks to bare text comparison in the -textOf:quals:.

[kmsbernard]

I found out that it is required to invalidate placeholder visibility in this method. I added a required commit.

[lunaleaps]

Thanks for your fix! Wondering if this was tested off of main and whether other languages have been tested to verify no regressions?

[kmsbernard]

Thanks for your fix! Wondering if this was tested off of main and whether other languages have been tested to verify no regressions?

I've tested some other languages with RNTester:

Chinese.mov

Japanese.mov

English.mov

[kmsbernard]

@philIip @p-sun Is there anything I can do to help move this forward?

[facebook-github-bot]

@philIip has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[pull-bot]

PR build artifact for 2dd1dc0 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[lunaleaps]

Thanks for the ping! I've reached out to @philIip to land

[kmsbernard]

@philIip Is there something I can do to move this forward?

[facebook-github-bot]

@philIip has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @bernard-kms in 1a83dc3.

^{When will my fix make it into a release? | Upcoming Releases}