Fix how KeyboardAvoidingView handles the onLayout prop. #32609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
|
@philIip has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
philIip
approved these changes
Nov 17, 2021
|
Thanks @philIip, I've updated the Test Plan with before and after screen caps 👍 |
|
@JeffreyHyer can you rebase and resubmit? i will go for the land. |
|
@philIip Just rebased, should be good to merge. |
|
@philIip has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
nawbc
pushed a commit
to NawbExplorer/react-native
that referenced
this pull request
Dec 7, 2021
Summary: Resolves facebook#32608 This PR updates the `KeyboardAvoidingView` to correctly handle the `onLayout` prop. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Fixed] - `onLayout` prop is handled correctly in `<KeyboardAvoidingView>` Pull Request resolved: facebook#32609 Test Plan: | Current Behavior with the `onLayout` prop specified | After applying fix | |---|---| |  |  | Reviewed By: kacieb Differential Revision: D32481315 Pulled By: philIip fbshipit-source-id: 2f65440f4996152e4133211136f2920026149ee9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #32608
This PR updates the
KeyboardAvoidingViewto correctly handle theonLayoutprop.Changelog
[General] [Fixed] -
onLayoutprop is handled correctly in<KeyboardAvoidingView>Test Plan
onLayoutprop specified