Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not virtualize items around the last focused item #32646

Closed
wants to merge 13 commits into from
Closed

Do not virtualize items around the last focused item #32646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
19cb111
Enable Generic Discontiguous Regions within VirtualizedList
NickGerleman Nov 21, 2021
8a9c4e2
Do not virtualize items adjacent to the last focused item
NickGerleman Nov 23, 2021
32e73ee
Do not rerender on focus change if mask doesn't change
NickGerleman Nov 23, 2021
2a5503e
Do not make assumptions on cell structure
NickGerleman Nov 23, 2021
f0de65b
office-shared-comments-ui ee041633
NickGerleman Dec 7, 2021
03f180f
Add more sophisticated logic for "last focused" render region
NickGerleman Dec 8, 2021
eb64202
Merge commit 'b2f871a6fa9c92dd0712055384b9eca6d828e37d' into realize-…
NickGerleman Jul 19, 2022
75cc358
Merge commit 'adb2962fee968d7ae20ec32a55dc69e4ebb3ce12' into realize-…
NickGerleman Jul 19, 2022
093968e
Merge commit '0c4c6ca319fa9dfb23d047e0c7d2a81281d1d8a3' into realize-…
NickGerleman Jul 19, 2022
7c23f47
Merge commit '23a160ebf66f6aac306f8db90ff79b945fe76ce2' into realize-…
NickGerleman Jul 20, 2022
d739bc3
Merge commit '73ad6514cc91d3df6b9c39713860ca71e8479ef3' into realize-…
NickGerleman Jul 20, 2022
65517fe
Merge commit 'b869680c1196a6549154a4b9cb7ffa10eab1989c' into realize-…
NickGerleman Jul 20, 2022
8437121
Merge remote-tracking branch 'origin/main' into realize-last-focused
NickGerleman Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Libraries/Components/View/ViewPropTypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@ import type {
export type ViewLayout = Layout;
export type ViewLayoutEvent = LayoutEvent;

type BubblingEventProps = $ReadOnly<{|
type FocusEventProps = $ReadOnly<{|
onBlur?: ?(event: BlurEvent) => mixed,
onBlurCapture?: ?(event: BlurEvent) => mixed,
onFocus?: ?(event: FocusEvent) => mixed,
onFocusCapture?: ?(event: FocusEvent) => mixed,
|}>;

type DirectEventProps = $ReadOnly<{|
Expand Down Expand Up @@ -394,7 +396,7 @@ type IOSViewProps = $ReadOnly<{|
|}>;

export type ViewProps = $ReadOnly<{|
...BubblingEventProps,
...FocusEventProps,
...DirectEventProps,
...GestureResponderEventProps,
...MouseEventProps,
Expand Down
4 changes: 4 additions & 0 deletions Libraries/Lists/CellRenderMask.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,10 @@ export class CellRenderMask {
);
}

numCells(): number {
return this._numCells;
}

equals(other: CellRenderMask): boolean {
return (
this._numCells === other._numCells &&
Expand Down
2 changes: 0 additions & 2 deletions Libraries/Lists/VirtualizeUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ export function computeWindowedRenderLimits(
prev: {
first: number,
last: number,
...
},
getFrameMetricsApprox: (index: number) => {
length: number,
Expand All @@ -120,7 +119,6 @@ export function computeWindowedRenderLimits(
): {
first: number,
last: number,
...
} {
const itemCount = getItemCount(data);
if (itemCount === 0) {
Expand Down
Loading