Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup a newArchEnabled property to Opt-in the New Architecture in the template #32790

Closed
wants to merge 1 commit into from

Conversation

cortinico
Copy link
Contributor

Summary:
As the name says, I've added a newArchEnabled property that can be used to toggle the
New Architecture in the new app template. Users can use this to try the New Architecture in their
project by either:

  • Set newArchEnabled to true inside the gradle.properties file
  • Invoke gradle with -PnewArchEnabled=true
  • Set an environment variable ORG_GRADLE_PROJECT_newArchEnabled=true

The Project property will also control if:

  • ReactNative dependency should be built from source or not.
  • The NDK should be enabled or not.

Please note that this requires RN 0.68.x to run properly (it won't work with 0.67 RCs) or a Nightly version of React Native.

Changelog:
[Android] [Added] - Setup a newArchEnabled property to Opt-in the New Architecture in the template

Differential Revision: D33065373

…he template

Summary:
As the name says, I've added a `newArchEnabled` property that can be used to toggle the
New Architecture in the new app template. Users can use this to try the New Architecture in their
project by either:
* Set `newArchEnabled` to true inside the `gradle.properties` file
* Invoke gradle with `-PnewArchEnabled=true`
* Set an environment variable `ORG_GRADLE_PROJECT_newArchEnabled=true`

The Project property will also control if:
* ReactNative dependency should be built from source or not.
* The NDK should be enabled or not.

Please note that this requires RN 0.68.x to run properly (it won't work with 0.67 RCs) or a Nightly version of React Native.

Changelog:
[Android] [Added] - Setup a `newArchEnabled` property to Opt-in the New Architecture in the template

Differential Revision: D33065373

fbshipit-source-id: d8423a36cf82c700743fd3396fe813f5d7472183
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Dec 21, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D33065373

@react-native-bot react-native-bot added Platform: Android Android applications. Type: Enhancement A new feature or enhancement of an existing feature. labels Dec 21, 2021
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: f142bfe
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,286,766 +0
android hermes armeabi-v7a 7,620,512 +0
android hermes x86 8,757,840 +0
android hermes x86_64 8,695,622 +0
android jsc arm64-v8a 9,675,105 +0
android jsc armeabi-v7a 8,665,526 +0
android jsc x86 9,631,671 +0
android jsc x86_64 10,227,045 +0

Base commit: f142bfe
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cortinico in 8d652fb.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Dec 21, 2021
@cortinico cortinico added the Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules) label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: Android Android applications. Type: Enhancement A new feature or enhancement of an existing feature. Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants