Do not remove libjscexecutor.so from release builds #32932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: As the title says, we dont' want to remove `libjscexecutor.so` when baking release builds and having JSC enable as this leads to instacrashes. Fixes facebook#32928 Fixes facebook#32927 Changelog: [Android] [Fixed] - Do not remove libjscexecutor.so from release builds Differential Revision: D33681932 fbshipit-source-id: 4a71fd6cfaae35a1f24f048648e32d78d573a457
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D33681932 |
Base commit: 4a227ce |
Base commit: 4a227ce |
|
This pull request was successfully merged by @cortinico in 574a773. When will my fix make it into a release? | Upcoming Releases |
lunaleaps
pushed a commit
that referenced
this pull request
Jan 20, 2022
Summary: Pull Request resolved: #32932 As the title says, we dont' want to remove `libjscexecutor.so` when baking release builds and having JSC enable as this leads to instacrashes. Fixes #32928 Fixes #32927 Changelog: [Android] [Fixed] - Do not remove libjscexecutor.so from release builds Reviewed By: ShikaSD Differential Revision: D33681932 fbshipit-source-id: 5b59fd1fb76c80c191198d65c916bbbd9232c75b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As the title says, we dont' want to remove
libjscexecutor.sowhenbaking release builds and having JSC enable as this leads to instacrashes.
Fixes #32928
Fixes #32927
Changelog:
[Android] [Fixed] - Do not remove libjscexecutor.so from release builds
Differential Revision: D33681932