Update template/android and RN Tester to use hermes-engine from the react-native NPM package.
#33467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `react-native` NPM package. Summary: We can now change the `hermes-engine` dependency to be consumed by the `react-native` NPM package and not anymore from the standalone `hermes-engine`. This will allow for a better stability as the `hermes-engine` and the `react-native` were built from source at the same instant in time. Changelog: [Android] [Changed] - Update template/android and RN Tester to use `hermes-engine` from the `react-native` NPM package. Reviewed By: hramos Differential Revision: D34213795 fbshipit-source-id: 4ec8c6fae202e616274be6d87d6ee110906af6cc
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D34213795 |
|
This pull request was successfully merged by @cortinico in 4d91f40. When will my fix make it into a release? | Upcoming Releases |
leotm
reviewed
May 4, 2022
Comment on lines
+9
to
+10
| include(":ReactAndroid:hermes-engine") | ||
| project(":ReactAndroid:hermes-engine").projectDir = file('../node_modules/react-native/ReactAndroid/hermes-engine') |
There was a problem hiding this comment.
nice ^ spotted/fixed in the nightly too earlier
but lagging few days behind 🤪 more contributions inc
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
… `react-native` NPM package. (facebook#33467) Summary: Pull Request resolved: facebook#33467 We can now change the `hermes-engine` dependency to be consumed by the `react-native` NPM package and not anymore from the standalone `hermes-engine`. This will allow for a better stability as the `hermes-engine` and the `react-native` were built from source at the same instant in time. Changelog: [Android] [Changed] - Update template/android and RN Tester to use `hermes-engine` from the `react-native` NPM package. Reviewed By: hramos Differential Revision: D34213795 fbshipit-source-id: 29e54b37db0103f72e9983976ef9147fe69116e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We can now change the
hermes-enginedependency to be consumed by thereact-nativeNPM packageand not anymore from the standalone
hermes-engine. This will allow for a better stabilityas the
hermes-engineand thereact-nativewere built from source at the same instant in time.Changelog:
[Android] [Changed] - Update template/android and RN Tester to use
hermes-enginefrom thereact-nativeNPM package.Reviewed By: hramos
Differential Revision: D34213795