-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump React Native Gradle plugin to 0.0.6 #33581
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We currently have some code on the RN Gradle Plugin that we need to ship. There are both bugfixes needed for RN 0.68.1 and for the current nightly (therefore needed for RN 0.69). I've verified that this works on a fresh RN 0.68.0 install with `npm pack` and triggering a build on a fresh setup from app template, with newArchEnabled set to true. Changelog: [Android] [Changed] - Bump React Native Gradle plugin to 0.0.6 Differential Revision: D35439444 fbshipit-source-id: 4d475c7d3b486c53c6bb290c0d16767faa7b566e
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
fb-exported
labels
Apr 6, 2022
This pull request was exported from Phabricator. Differential Revision: D35439444 |
Base commit: 8dfbed7 |
Base commit: 8dfbed7 |
This pull request was successfully merged by @cortinico in 9573d7b. When will my fix make it into a release? | Upcoming Releases |
cortinico
added
the
Type: New Architecture
Issues and PRs related to new architecture (Fabric/Turbo Modules)
label
Apr 12, 2022
fortmarek
pushed a commit
that referenced
this pull request
Apr 13, 2022
Summary: Pull Request resolved: #33581 We currently have some code on the RN Gradle Plugin that we need to ship. There are both bugfixes needed for RN 0.68.1 and for the current nightly (therefore needed for RN 0.69). I've verified that this works on a fresh RN 0.68.0 install with `npm pack` and triggering a build on a fresh setup from app template, with newArchEnabled set to true. Changelog: [Android] [Changed] - Bump React Native Gradle plugin to 0.0.6 Reviewed By: rubennorte Differential Revision: D35439444 fbshipit-source-id: 662b2211c44b261e3e3c9cddc946107cfb495c79
This was referenced Nov 14, 2022
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary: Pull Request resolved: facebook#33581 We currently have some code on the RN Gradle Plugin that we need to ship. There are both bugfixes needed for RN 0.68.1 and for the current nightly (therefore needed for RN 0.69). I've verified that this works on a fresh RN 0.68.0 install with `npm pack` and triggering a build on a fresh setup from app template, with newArchEnabled set to true. Changelog: [Android] [Changed] - Bump React Native Gradle plugin to 0.0.6 Reviewed By: rubennorte Differential Revision: D35439444 fbshipit-source-id: 662b2211c44b261e3e3c9cddc946107cfb495c79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Platform: Android
Android applications.
Type: New Architecture
Issues and PRs related to new architecture (Fabric/Turbo Modules)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We currently have some code on the RN Gradle Plugin that we need to ship.
There are both bugfixes needed for RN 0.68.1 and for the current nightly
(therefore needed for RN 0.69).
I've verified that this works on a fresh RN 0.68.0 install with
npm pack
and triggering a build on a fresh setup from app template, with newArchEnabled set to true.
Changelog:
[Android] [Changed] - Bump React Native Gradle plugin to 0.0.6
Differential Revision: D35439444