Expose an API to enable Concurrent Root on Android #33645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: With React 18, we now need to allow users on Fabric to opt-in for Concurrent Root. This commit adds a new method that can be called on the ReactActivityDelegate that can be used to set the `concurrentRoot` flag on the `initialProps` on the Render. Changelog: [Android] [Added] - Expose an API to enable Concurrent Root on Android Reviewed By: mdvacca Differential Revision: D35614879 fbshipit-source-id: 2c40f060c1d1bdbffdeb97302348ced995ddbd88
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D35614879 |
react-native-bot
added
Platform: Android
Base commit: a223874 |
Base commit: a223874 |
|
This pull request was successfully merged by @cortinico in d7b64b8. When will my fix make it into a release? | Upcoming Releases |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary: Pull Request resolved: facebook#33645 With React 18, we now need to allow users on Fabric to opt-in for Concurrent Root. This commit adds a new method that can be called on the ReactActivityDelegate that can be used to set the `concurrentRoot` flag on the `initialProps` on the Render. Changelog: [Android] [Added] - Expose an API to enable Concurrent Root on Android Reviewed By: mdvacca Differential Revision: D35614879 fbshipit-source-id: 2de83e8115d3748c0346cdec6f31b2ab1f899478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
With React 18, we now need to allow users on Fabric to opt-in for Concurrent Root.
This commit adds a new method that can be called on the ReactActivityDelegate
that can be used to set the
concurrentRootflag on theinitialPropson the Render.Changelog:
[Android] [Added] - Expose an API to enable Concurrent Root on Android
Reviewed By: mdvacca
Differential Revision: D35614879