iOS: Use pre-built hermesc if available #33827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D36024615 |
Base commit: d7921f0 |
|
This pull request was exported from Phabricator. Differential Revision: D36024615 |
hramos
added a commit
to hramos/react-native
that referenced
this pull request
May 13, 2022
Summary: Pull Request resolved: facebook#33827 Use pre-built hermesc if available by generating a ImportHermesc.cmake file that points to the hermesc binary. Hermes build scripts have been updated to support a `HERMES_OVERRIDE_HERMESC_PATH` envvar which can point to this generated ImportHermesc.cmake file. Changelog: [iOS] [Changed] - Use pre-built HermesC if available in current React Native release Differential Revision: D36024615 fbshipit-source-id: e0ccae0737b989df267f6041e33550e9eb00bc59
Summary: Pull Request resolved: facebook#33827 Use pre-built hermesc if available by generating a ImportHermesc.cmake file that points to the hermesc binary. Hermes build scripts have been updated to support a `HERMES_OVERRIDE_HERMESC_PATH` envvar which can point to this generated ImportHermesc.cmake file. Changelog: [iOS] [Changed] - Use pre-built HermesC if available in current React Native release Differential Revision: D36024615 fbshipit-source-id: d5be72106ab8cf80d54276b3ae8899a7c769d787
|
This pull request was exported from Phabricator. Differential Revision: D36024615 |
Base commit: d7921f0 |
|
This pull request was successfully merged by @hramos in 644fe43. When will my fix make it into a release? | Upcoming Releases |
fortmarek
pushed a commit
that referenced
this pull request
May 20, 2022
Summary: Use pre-built hermesc if available by generating a ImportHermesc.cmake file that points to the hermesc binary. Recent `react-native` releases should have hermesc available in sdks/hermesc. Hermes build scripts have been updated to support a `HERMES_OVERRIDE_HERMESC_PATH` envvar which can point to this generated ImportHermesc.cmake file. Pull Request resolved: #33827 Changelog: [iOS] [Changed] - Use pre-built HermesC if available in current React Native release Reviewed By: cortinico Differential Revision: D36024615 fbshipit-source-id: 476569f73309f9bd142f28cb02d1f7d57b6cbc6a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Use pre-built hermesc if available by generating a ImportHermesc.cmake file that points to the hermesc binary.
Hermes build scripts have been updated to support a
HERMES_OVERRIDE_HERMESC_PATHenvvar which can point to this generated ImportHermesc.cmake file.Changelog:
[iOS] [Changed] - Use pre-built HermesC if available in current React Native release
Differential Revision: D36024615