Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Avoid installing Flipper in CI #33899

Closed
wants to merge 1 commit into from
Closed

[Feat] Avoid installing Flipper in CI #33899

wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented May 24, 2022 •
edited
Loading

Summary

This PR speeds up the build in CircleCI by avoiding adding Flipper dependency when running in CI.

The savings are:

  • ~ 13/15% for test_ios
  • ~ 30/40% for test_rntester
  • 50% for test_ios_template

Edit after review: We do actually want to have Flipper in the test_ios_template to check that it builds correctly.

Changelog

[iOS] [Changed] - Do not add Flipper when running in CI.

Test Plan

CircleCI passing with these stats:

BEFORE AFTER
FlipperCI-Before FlipperCI-After

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 24, 2022
@react-native-bot react-native-bot added the Platform: iOS iOS applications. label May 24, 2022
@analysis-bot
Copy link

analysis-bot commented May 24, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 8363184
Branch: main

@analysis-bot
Copy link

analysis-bot commented May 24, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,791,503 +0
android hermes armeabi-v7a 7,195,515 +0
android hermes x86 8,103,349 +0
android hermes x86_64 8,081,160 +0
android jsc arm64-v8a 9,660,046 +0
android jsc armeabi-v7a 8,432,909 +0
android jsc x86 9,612,704 +0
android jsc x86_64 10,207,447 +0

Base commit: 8363184
Branch: main

@cipolleschi cipolleschi marked this pull request as ready for review May 24, 2022 10:06
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label May 24, 2022
@cipolleschi cipolleschi changed the title test: add check for CI [Feat] Avoid installing Flipper in CI May 24, 2022
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cortinico
cortinico reviewed May 24, 2022
View reviewed changes
template/ios/Podfile Outdated
Comment on lines 36 to 38
if !IN_CI then
use_flipper!()
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up that this would reduce our confidence on having Flipper working on the new app template. I'm not sure we want to do this.

On Android, we always include Flipper regardless of CI.

I can understand the win on build time for a RN user, but as we're testing the default template here, it probably makes sense to make sure Flipper is also included in the build

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Avoid installing Flipper in CI (facebook#33899)
82217c7 
Summary:
This PR speeds up the build in CircleCI by avoiding adding Flipper dependency when running in CI.

The savings are:
* ~ 13/15% for `test_ios`
* ~ 30/40% for `test_rntester`
* ~50% for `test_ios_template`~

**Edit after review**: We do actually want to have Flipper in the `test_ios_template` to check that it builds correctly.

## Changelog
[iOS] [Changed] - Do not add Flipper when running in CI.

Pull Request resolved: facebook#33899

Test Plan:
CircleCI passing with these stats:

| BEFORE | AFTER |
| ---- | ---- |
| <img width="663" alt="FlipperCI-Before" src="https://user-images.githubusercontent.com/11162307/170006493-2651b000-0421-47c3-90e9-153474c15a95.png"> | <img width="652" alt="FlipperCI-After" src="https://user-images.githubusercontent.com/11162307/170006557-34e53601-66b4-4054-a156-0e2349f48dc2.png"> |

Reviewed By: cortinico

Differential Revision: D36625117

Pulled By: cipolleschi

fbshipit-source-id: 2bc8dc9e3d8f4b53d74379443f42a68933f63ab5
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36625117

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cipolleschi in ad76eb3.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: iOS iOS applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cipolleschi @analysis-bot @facebook-github-bot @react-native-bot @cortinico