Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yoga] revert #33381 changes #33973

Closed
wants to merge 2 commits into from
Closed

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Jun 7, 2022

Summary

facebook/yoga#1150 is better than the tricky #33381 and fix the build error on react-native 0.69 with swift clang module. as facebook/yoga#1150 is landed as 43f831b, i'm reverting the previous change, only leaving the necessary react_native_pods.rb change.

Changelog

[iOS] [Changed] - Better fix for yoga + swift clang module build error

Test Plan

ci passed

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Expo Partner: Expo Partner labels Jun 7, 2022
@react-native-bot react-native-bot added the Platform: iOS iOS applications. label Jun 7, 2022
@analysis-bot
Copy link

analysis-bot commented Jun 7, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,782,249 -169
android hermes armeabi-v7a 7,172,078 -59
android hermes x86 8,092,958 -100
android hermes x86_64 8,068,952 -145
android jsc arm64-v8a 9,649,085 -394
android jsc armeabi-v7a 8,407,885 -284
android jsc x86 9,600,644 -344
android jsc x86_64 10,193,678 -379

Base commit: edb27e3
Branch: main

@Kudo Kudo marked this pull request as ready for review June 7, 2022 23:27
@analysis-bot
Copy link

analysis-bot commented Jun 8, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: edb27e3
Branch: main

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jun 8, 2022
@facebook-github-bot
Copy link
Contributor

@dmitryrykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Jun 10, 2022
Summary:
Changelog:
[Internal][Fixed] - #33973 breaks the internal CI, as it depends on the outdated offline mirror for `Pods/Target Support Files`.

Reviewed By: cortinico

Differential Revision: D37038213

fbshipit-source-id: 1d27c9c32f2c3ddecd15a83935c520d1e1524b21
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Kudo in c2088e1.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 10, 2022
Kudo added a commit to expo/react-native that referenced this pull request Jun 23, 2022
Summary:
facebook/yoga#1150 is better than the tricky facebook#33381 and fix the build error on react-native 0.69 with swift clang module. as facebook/yoga#1150 is landed as facebook@43f831b, i'm reverting the previous change, only leaving the necessary react_native_pods.rb change.

## Changelog

[iOS] [Changed] - Better fix for yoga + swift clang module build error

Pull Request resolved: facebook#33973

Test Plan: ci passed

Reviewed By: cortinico, cipolleschi

Differential Revision: D36998007

Pulled By: dmitryrykun

fbshipit-source-id: fa11bd950e2a1be6396f286086f4e7941ad2ff5b
(cherry picked from commit c2088e1)
fortmarek pushed a commit that referenced this pull request Jun 29, 2022
Summary:
facebook/yoga#1150 is better than the tricky #33381 and fix the build error on react-native 0.69 with swift clang module. as facebook/yoga#1150 is landed as 43f831b, i'm reverting the previous change, only leaving the necessary react_native_pods.rb change.

## Changelog

[iOS] [Changed] - Better fix for yoga + swift clang module build error

Pull Request resolved: #33973

Test Plan: ci passed

Reviewed By: cortinico, cipolleschi

Differential Revision: D36998007

Pulled By: dmitryrykun

fbshipit-source-id: fa11bd950e2a1be6396f286086f4e7941ad2ff5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. p: Expo Partner: Expo Partner Platform: iOS iOS applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants