Fix HBC_SOURCEMAP_FILE in scripts/react-native-xcode.sh

[kidroca]

Summary

Fixes #32497
Fixes #34212

The assigned HBC_SOURCEMAP_FILE path is incorrect as it does not reference the hermes bundle source map file

See: #32497 (comment)

Changelog

[General] [Fixed] - using SOURCEMAP_FILE during xcode build phase with Hermes enabled

Test Plan

1. In a blank react-native project
2. Enable Hermes
3. Go to xCode -> Project -> Build Phases -> Bundle React Native code and images
4. Add export SOURCEMAP_FILE="$(pwd)/../ios.jsbundle.map" before react-native-xcode.sh
   e.g.

   export NODE_BINARY=node
   export SOURCEMAP_FILE="$(pwd)/../ios.jsbundle.map"
   
   ../node_modules/react-native/scripts/react-native-xcode.sh

5. Make a release build npx react-native run-ios --configuration Release or CMD + I in xCode
6. Verify the build is successful
7. Verify the .map file is outputted at the specified path (ios.jsbundle.map in project root for the example above)

[kidroca]

Summary

Addresses #32497

The assigned HBC_SOURCEMAP_FILE path is incorrect as it does not reference the hermes bundle source map file

See: #32497 (comment)

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,610,280	-13
android	hermes	armeabi-v7a	7,025,994	-9
android	hermes	x86	7,910,168	-6
android	hermes	x86_64	7,883,441	+3
android	jsc	arm64-v8a	9,488,705	-2
android	jsc	armeabi-v7a	8,266,578	-7
android	jsc	x86	9,426,078	-5
android	jsc	x86_64	10,018,839	+15

Base commit: 33dbb6c
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: b4f6262
Branch: main

[facebook-github-bot]

@dmitryrykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[dmytrorykun]

Hey @kidroca, could you please rebase this PR on top of main to make CI happy?

[kidroca]

Hey @kidroca, could you please rebase this PR on top of main to make CI happy?

Rebased

[facebook-github-bot]

@dmitryrykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[iBotPeaches]

Not to hijack a merged issue, but after reading this and wanting to debug some Hermes source maps I can't find a single official source for enabling basic sourcemaps on ios w/ Hermes. Which is possible - I'm just blind, but I've spent a few hours on this.

• Stackoverflow says EXTRA_PACKAGER_ARGS
• Sentry has their own script I presume they RE`d from here
• Bugsnag has their own script as well
• Official docs only mention the Android process

I ended up trying this via reading this merge.

export SOURCEMAP_FILE=\"$(pwd)/../main.jsbundle.map\";

Prior to "Bundle React Native code and images" step where the exported vars are being set. This seemed to work great, but I'm unsure if 4 sources say 4 different things what is expected. I can assure you with any official help here to point to what is officially recommend - I will turn around and PR the docs for the process.

[dmytrorykun]

@iBotPeaches, yeah, defining SOURCEMAP_FILE envvar is the right way for enabling source maps.

[iBotPeaches]

thanks @dmitryrykun

Working on a doc pr now.

[iBotPeaches]

Started a brand new doc for sourcemaps - facebook/react-native-website#3293 - ready for feedback.