Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's not build reactnativeutilsjni shared library #34345

Merged
merged 1 commit into from
Aug 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ LOCAL_SHARED_LIBRARIES := \
libreact_render_uimanager \
libreact_utils \
libreact_config \
libreactnativeutilsjni \
libreactnativejni \
librrc_image \
librrc_root \
librrc_unimplementedview \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH)

LOCAL_CFLAGS += -fexceptions -frtti -std=c++17 -Wall

LOCAL_SHARED_LIBRARIES = libfb libfbjni libreactnativeutilsjni libruntimeexecutor
LOCAL_SHARED_LIBRARIES = libfb libfbjni libreactnativejni libruntimeexecutor

LOCAL_STATIC_LIBRARIES = libcallinvoker libreactperfloggerjni

Expand Down
60 changes: 0 additions & 60 deletions ReactAndroid/src/main/jni/react/jni/Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -3,67 +3,8 @@
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.


##########################
### React Native Utils ###
##########################

LOCAL_PATH := $(call my-dir)

include $(CLEAR_VARS)

# Include . in the header search path for all source files in this module.
LOCAL_C_INCLUDES := $(LOCAL_PATH)

# Include ./../../ in the header search path for modules that depend on
# reactnativejni. This will allow external modules to require this module's
# headers using #include <react/jni/<header>.h>, assuming:
# . == jni
# ./../ == react
LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH)/../..

LOCAL_CFLAGS += -fexceptions -frtti -Wno-unused-lambda-capture

LOCAL_LDLIBS += -landroid

# The dynamic libraries (.so files) that this module depends on.
LOCAL_SHARED_LIBRARIES := \
libfb \
libfbjni \
libfolly_json \
libglog_init \
libreact_render_runtimescheduler \
libruntimeexecutor \
libyoga

# The static libraries (.a files) that this module depends on.
LOCAL_STATIC_LIBRARIES := libreactnative libcallinvokerholder

# Name of this module.
#
# Other modules can depend on this one by adding libreactnativejni to their
# LOCAL_SHARED_LIBRARIES variable.
LOCAL_MODULE := reactnativeutilsjni

# Compile all local c++ files.
LOCAL_SRC_FILES := $(wildcard $(LOCAL_PATH)/*.cpp)
LOCAL_SRC_FILES := $(subst $(LOCAL_PATH)/,,$(LOCAL_SRC_FILES))

ifeq ($(APP_OPTIM),debug)
# Keep symbols by overriding the strip command invoked by ndk-build.
# Note that this will apply to all shared libraries,
# i.e. shared libraries will NOT be stripped
# even though we override it in this Android.mk
cmd-strip :=
endif

# Build the files in this directory as a shared library
include $(BUILD_SHARED_LIBRARY)





######################
### reactnativejni ###
######################
Expand Down Expand Up @@ -91,7 +32,6 @@ LOCAL_SHARED_LIBRARIES := \
libfolly_json \
libglog_init \
libreact_render_runtimescheduler \
libreactnativeutilsjni \
libruntimeexecutor \
libyoga \
logger
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ LOCAL_SHARED_LIBRARIES := \
libreact_render_debug \
libreact_render_graphics \
libreact_render_uimanager \
libreactnativeutilsjni \
libreactnativejni \
librrc_view \
libyoga

Expand Down
2 changes: 1 addition & 1 deletion ReactCommon/react/renderer/components/slider/Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ LOCAL_SHARED_LIBRARIES := \
libreact_render_imagemanager \
libreact_render_mapbuffer \
libreact_render_uimanager \
libreactnativeutilsjni \
libreactnativejni \
librrc_image \
librrc_view \
libyoga
Expand Down
2 changes: 1 addition & 1 deletion ReactCommon/react/renderer/components/switch/Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ LOCAL_SHARED_LIBRARIES := \
libreact_render_debug \
libreact_render_graphics \
libreact_render_uimanager \
libreactnativeutilsjni \
libreactnativejni \
librrc_view \
libyoga

Expand Down
2 changes: 1 addition & 1 deletion ReactCommon/react/renderer/textlayoutmanager/Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ LOCAL_SHARED_LIBRARIES := \
libreact_render_telemetry \
libreact_render_uimanager \
libreact_utils \
libreactnativeutilsjni \
libreactnativejni \
libyoga

LOCAL_STATIC_LIBRARIES :=
Expand Down