Enable pedantic warnings in C++ podspecs #34404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This change mirrors D38457812 (facebook@063c2b4) which added -Wpedantic to ReactCommon targets, but for the Android build used by OSS. This should ensure contributors see the same warnings locally as the internal build would produce. Changelog: [Android][Changed] - Enable -Wpedantic in OSS Android Targets Differential Revision: D38632454 fbshipit-source-id: d00d1262673d46f98b6e65ba372e33943523dbe5
Summary: Mirrors D38457812 (facebook@063c2b4) and D38632454, this enables pedantic warnings for iOS in OSS, so that the warning level matches the internal. This is enabled through the `GCC_WARN_PEDANTIC` xcconfig flag (confusingly part of "Apple Clang - Warning Policies"), which controls whether "-pedantic" is passed. Changelog: [iOS][Changed] - Enable pedantic errors in C++ podspecs Differential Revision: D38681644 fbshipit-source-id: 3fc162d5eeedb26034cb50f112978ee9eee168e3
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D38681644 |
NickGerleman
changed the title
Base commit: b8425c8 |
Base commit: b8425c8 |
|
This pull request was successfully merged by @NickGerleman in 545c82b. When will my fix make it into a release? | Upcoming Releases |
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: Pull Request resolved: facebook#34404 Mirrors D38457812 (facebook@063c2b4) and D38632454 (facebook@06b55a3), this enables pedantic warnings for iOS in OSS, so that the warning level matches the internal. This is enabled through the `GCC_WARN_PEDANTIC` xcconfig flag (part of "Apple Clang - Warning Policies"), which controls whether "-pedantic" is passed to clang. Changelog: [iOS][Changed] - Enable pedantic warnings in C++ podspecs Reviewed By: cipolleschi Differential Revision: D38681644 fbshipit-source-id: 724160fbe03660fcfd12ea0ffeedaab448c66a5f
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: Pull Request resolved: facebook#34404 Mirrors D38457812 (facebook@063c2b4) and D38632454 (facebook@06b55a3), this enables pedantic warnings for iOS in OSS, so that the warning level matches the internal. This is enabled through the `GCC_WARN_PEDANTIC` xcconfig flag (part of "Apple Clang - Warning Policies"), which controls whether "-pedantic" is passed to clang. Changelog: [iOS][Changed] - Enable pedantic warnings in C++ podspecs Reviewed By: cipolleschi Differential Revision: D38681644 fbshipit-source-id: 724160fbe03660fcfd12ea0ffeedaab448c66a5f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Mirrors D38457812 (063c2b4) and D38632454, this enables pedantic warnings for iOS in OSS, so that the warning level matches the internal.
This is enabled through the
GCC_WARN_PEDANTICxcconfig flag (confusingly part of "Apple Clang - Warning Policies"), which controls whether "-pedantic" is passed.Changelog:
[iOS][Changed] - Enable pedantic errors in C++ podspecs
Differential Revision: D38681644