Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CircleCI run shallow clones of the React Native repo #34455

Closed

Conversation

throwaway-fishery
Copy link
Contributor

@throwaway-fishery throwaway-fishery commented Aug 19, 2022

This PR tries to fix the CI considering three use cases:

  • CI running on main
  • CI running on a branch in the React Native repo
  • CI running on a PR opened from a fork

Changelog

[General][Fixed] - Fix shallow cloning break on main.

Introduced in #34438
Failed to fix in #34453

Differential Revision: D38859731

Summary:
# Changelog
[General][Fixed] - Fix shallow cloning break on main.

Introduced in [facebook#34438](facebook#34438)
Failed to fix in [facebook#34453](facebook#34453)

Differential Revision: D38859731

fbshipit-source-id: 6a5749fa06c82a6d6e4bc27e3a52fd41e24a2fbe
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Aug 19, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D38859731

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 4eec473
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,615,166 +310
android hermes armeabi-v7a 7,030,150 +365
android hermes x86 7,915,638 +49
android hermes x86_64 7,889,604 +294
android jsc arm64-v8a 9,494,197 +412
android jsc armeabi-v7a 8,272,050 +389
android jsc x86 9,432,261 +380
android jsc x86_64 10,025,334 +417

Base commit: 4eec473
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @throwaway-fishery in e142de0.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Aug 19, 2022
@throwaway-fishery throwaway-fishery deleted the export-D38859731 branch August 19, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants