Only show warning when overwrite existing preprocessor #34479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 163171c |
facebook-github-bot
added
the
Shared with Meta
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Kudo
force-pushed
the
setStyleAttributePreprocessor-warning
branch
from
f380aec
to
e35e81c
Compare
|
also rebase this one for ci fixes |
Base commit: 163171c |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @Kudo in 82ceb8c. When will my fix make it into a release? | Upcoming Releases |
raykle
pushed a commit
to raykle/react-native
that referenced
this pull request
Aug 27, 2022
Summary: from the original design of `StyleSheet.setStyleAttributePreprocessor()` in facebook#11138, the overwriting warning shows when the existing preprocess is be overwritten. the behavior changes from facebook@33b385825c72. This PR revises the logic back to original design. ## Changelog [Internal] [Fixed] - Show warning only when overwriting existing preprocessor in `StyleSheet.setStyleAttributePreprocessor()` Pull Request resolved: facebook#34479 Test Plan: Unit Test ``` PASS Libraries/StyleSheet/__tests__/StyleSheet-test.js setStyleAttributePreprocessor ✓ should not show warning when set preprocessor first time (2 ms) ✓ should show warning when overwrite the preprocessor (1 ms) ``` Reviewed By: dmitryrykun Differential Revision: D38940676 Pulled By: cipolleschi fbshipit-source-id: 80cf30fff62f4a02c17f7f42b3260a6011d5fc82
dmytrorykun
pushed a commit
that referenced
this pull request
Sep 14, 2022
Summary: from the original design of `StyleSheet.setStyleAttributePreprocessor()` in #11138, the overwriting warning shows when the existing preprocess is be overwritten. the behavior changes from 33b385825c72. This PR revises the logic back to original design. ## Changelog [Internal] [Fixed] - Show warning only when overwriting existing preprocessor in `StyleSheet.setStyleAttributePreprocessor()` Pull Request resolved: #34479 Test Plan: Unit Test ``` PASS Libraries/StyleSheet/__tests__/StyleSheet-test.js setStyleAttributePreprocessor ✓ should not show warning when set preprocessor first time (2 ms) ✓ should show warning when overwrite the preprocessor (1 ms) ``` Reviewed By: dmitryrykun Differential Revision: D38940676 Pulled By: cipolleschi fbshipit-source-id: 80cf30fff62f4a02c17f7f42b3260a6011d5fc82
3 tasks
Kudo
added a commit
to expo/expo
that referenced
this pull request
Oct 5, 2022
…9318) # Why follow up #17138 (comment). close ENG-4745 # How the fix facebook/react-native#34479 is landed in react-native 0.70.1. now we can remove the workaround. # Test Plan ios unversioned expo go + NCL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
from the original design of
StyleSheet.setStyleAttributePreprocessor()in #11138, the overwriting warning shows when the existing preprocess is be overwritten. the behavior changes from 33b385825c72. This PR revises the logic back to original design.Changelog
[Internal] [Fixed] - Show warning only when overwriting existing preprocessor in
StyleSheet.setStyleAttributePreprocessor()Test Plan
Unit Test