fix: Crash if WebView is disabled #34483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 2452c5f |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @Pajn, thanks for the PR. Could you please rebase on main? We should have fixed the CI issues. |
|
Sorry to ask that, but could you rebase again? The CI is still red but for some other commits that landed in between.. :( |
Base commit: 2452c5f |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Pajn
force-pushed
the
patch-1
branch
2 times, most recently
from
cf47331
to
a68ab50
Compare
|
Sorry, my additions skipped the earlier nullcheck. It should be correct now. |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @Pajn in 5451cd4. When will my fix make it into a release? | Upcoming Releases |
dmytrorykun
pushed a commit
that referenced
this pull request
Sep 14, 2022
Summary: When the webview is updated by play store, all apps that has loaded webview gets killed. For background see https://issuetracker.google.com/issues/228611949?pli=1 We have a long-running app and don't want this to happen and while we are not using webview anywhere, we are using websockets that loads it for reading cookies, however we are not using cookies to authenticate the websocket and thus want to disable the webview to avoid loading it unnecessarily and then getting killed unnecessarily. The webview has support for beeing disabled https://developer.android.com/reference/android/webkit/WebView#disableWebView() however as-is this crashes React Native. It seems to me like this case is very similar to not having web view installed and should be handled in the same way. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Fixed] - Avoid crash in ForwardingCookieHandler if webview is disabled Pull Request resolved: #34483 Test Plan: Add `WebView.disableWebView();` as the first line in `MainActivity.onCreate`. Reviewed By: christophpurrer Differential Revision: D38981827 Pulled By: cipolleschi fbshipit-source-id: 335a8420568ad0c80b834ae8a3b164e55ebe26f3
rthic23
pushed a commit
to electrode-io/react-native
that referenced
this pull request
May 23, 2023
Summary: When the webview is updated by play store, all apps that has loaded webview gets killed. For background see https://issuetracker.google.com/issues/228611949?pli=1 We have a long-running app and don't want this to happen and while we are not using webview anywhere, we are using websockets that loads it for reading cookies, however we are not using cookies to authenticate the websocket and thus want to disable the webview to avoid loading it unnecessarily and then getting killed unnecessarily. The webview has support for beeing disabled https://developer.android.com/reference/android/webkit/WebView#disableWebView() however as-is this crashes React Native. It seems to me like this case is very similar to not having web view installed and should be handled in the same way. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Fixed] - Avoid crash in ForwardingCookieHandler if webview is disabled Pull Request resolved: facebook#34483 Test Plan: Add `WebView.disableWebView();` as the first line in `MainActivity.onCreate`. Reviewed By: christophpurrer Differential Revision: D38981827 Pulled By: cipolleschi fbshipit-source-id: 335a8420568ad0c80b834ae8a3b164e55ebe26f3 # Conflicts: # ReactAndroid/src/main/java/com/facebook/react/modules/network/ForwardingCookieHandler.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the webview is updated by play store, all apps that has loaded webview gets killed. For background see https://issuetracker.google.com/issues/228611949?pli=1
We have a long-running app and don't want this to happen and while we are not using webview anywhere, we are using websockets that loads it for reading cookies, however we are not using cookies to authenticate the websocket and thus want to disable the webview to avoid loading it unnecessarily and then getting killed unnecessarily.
The webview has support for beeing disabled https://developer.android.com/reference/android/webkit/WebView#disableWebView() however as-is this crashes React Native. It seems to me like this case is very similar to not having web view installed and should be handled in the same way.
Changelog
[Android] [Fixed] - Avoid crash in ForwardingCookieHandler if webview is disabled
Test Plan
Add
WebView.disableWebView();as the first line inMainActivity.onCreate.