Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added aria-modal as alias for accessibilityViewIsModal(iOS) #34506

Closed
wants to merge 11 commits into from
Closed

feat: added aria-modal as alias for accessibilityViewIsModal(iOS) #34506

wants to merge 11 commits into from

Conversation

dakshbhardwaj
Copy link
Contributor

@dakshbhardwaj dakshbhardwaj commented Aug 26, 2022 •
edited
Loading

Summary

This adds the aria-modal prop to the components where it's used as requested on #34424, mapping web aria-modal to equivalent accessibilityViewIsModal

Changelog

[General] [Added] - Add aria-modal prop to basic component

TestPlan

Checked manually we are receiving the values by props.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2022
@github-actions
Copy link

github-actions bot commented Aug 26, 2022 •
edited
Loading

Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against ad116e0

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 26, 2022
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Aug 26, 2022
@analysis-bot
Copy link

analysis-bot commented Aug 26, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,641,629 +467
android hermes armeabi-v7a 7,053,984 +461
android hermes x86 7,943,406 +475
android hermes x86_64 7,915,311 +462
android jsc arm64-v8a 9,514,777 +390
android jsc armeabi-v7a 8,290,381 +382
android jsc x86 9,454,094 +379
android jsc x86_64 10,045,174 +390

Base commit: 82e9c6a
Branch: main

@cipolleschi
Copy link
Contributor

Hi @dakshbhardwaj, thanks for your PR. Could you please rebse this on main?

@dakshbhardwaj
Copy link
Contributor Author

dakshbhardwaj commented Aug 26, 2022 •
edited
Loading

Hi @dakshbhardwaj, thanks for your PR. Could you please rebse this on main?

@cipolleschi I have rebased it with main

@analysis-bot
Copy link

analysis-bot commented Aug 26, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: e8739e9
Branch: main

@facebook-github-bot
Copy link
Contributor

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@necolas necolas mentioned this pull request Aug 26, 2022
Closed
70 tasks
@facebook-github-bot
Copy link
Contributor

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jacdebug
jacdebug requested changes Sep 9, 2022
View reviewed changes
Libraries/Components/Pressable/Pressable.js Outdated
Comment on lines 252 to 254
restProps['aria-modal'] !== null
? restProps['aria-modal']
: restProps.accessibilityViewIsModal,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
restProps['aria-modal'] !== null
? restProps['aria-modal']
: restProps.accessibilityViewIsModal,
restProps['aria-modal'] ?? restProps.accessibilityViewIsModal,

Libraries/Components/Touchable/TouchableBounce.js Outdated
Comment on lines 168 to 170
this.props['aria-modal'] !== null
? this.props['aria-modal']
: this.props.accessibilityViewIsModal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.props['aria-modal'] !== null
? this.props['aria-modal']
: this.props.accessibilityViewIsModal
this.props['aria-modal'] ?? this.props.accessibilityViewIsModal

Libraries/Components/Touchable/TouchableHighlight.js Outdated
Comment on lines 314 to 316
this.props['aria-modal'] !== null
? this.props['aria-modal']
: this.props.accessibilityViewIsModal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.props['aria-modal'] !== null
? this.props['aria-modal']
: this.props.accessibilityViewIsModal
this.props['aria-modal'] ?? this.props.accessibilityViewIsModal

Libraries/Components/Touchable/TouchableNativeFeedback.js Outdated
Comment on lines 305 to 307
this.props['aria-modal'] !== null
? this.props['aria-modal']
: this.props.accessibilityViewIsModal,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.props['aria-modal'] !== null
? this.props['aria-modal']
: this.props.accessibilityViewIsModal,
this.props['aria-modal'] ?? this.props.accessibilityViewIsModal,

Libraries/Components/Touchable/TouchableOpacity.js Outdated
Comment on lines 260 to 262
this.props['aria-modal'] !== null
? this.props['aria-modal']
: this.props.accessibilityViewIsModal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.props['aria-modal'] !== null
? this.props['aria-modal']
: this.props.accessibilityViewIsModal
this.props['aria-modal'] ?? this.props.accessibilityViewIsModal

@dakshbhardwaj
Copy link
Contributor Author

@jacdebug i have pushed the changes

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @dakshbhardwaj in 095f19a.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 12, 2022
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@OlimpiaZurek
feat: added aria-modal as alias for accessibilityViewIsModal(iOS) (fa…
22b8bf5 
…cebook#34506)

Summary:
This adds the `aria-modal` prop to the components where it's used as requested on facebook#34424, mapping web [aria-modal](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-modal) to equivalent [accessibilityViewIsModal](iOS)

## Changelog
[General] [Added] - Add aria-modal  prop to basic component

## TestPlan
Checked manually we are receiving the values by props.

Pull Request resolved: facebook#34506

Reviewed By: jacdebug

Differential Revision: D39060396

Pulled By: cipolleschi

fbshipit-source-id: 80da100ff412b17ba29ddc6d811afb4b0207ac9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@necolas necolas necolas left review comments

@jacdebug jacdebug jacdebug approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dakshbhardwaj @analysis-bot @cipolleschi @facebook-github-bot @react-native-bot @necolas @jacdebug