Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: asset source resolver typo #34520

Closed
wants to merge 1 commit into from
Closed

fix: asset source resolver typo #34520

wants to merge 1 commit into from

Conversation

dhruvtailor7
Copy link
Contributor

Summary

Small typo fix.

Changelog

[General] [Fixed] - Typo in AssetSourceResolver

Test Plan

No test plan is required. Just check the file changes.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Aug 28, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,617,868 -4
android hermes armeabi-v7a 7,032,119 +0
android hermes x86 7,917,932 +1
android hermes x86_64 7,891,547 -1
android jsc arm64-v8a 9,495,283 +0
android jsc armeabi-v7a 8,272,914 +0
android jsc x86 9,433,074 +0
android jsc x86_64 10,026,064 +0

Base commit: ed21a3e
Branch: main

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: ed21a3e
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @dhruvtailor7 in a45eeea.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Aug 28, 2022
raykle pushed a commit to raykle/react-native that referenced this pull request Aug 29, 2022
@raykle
fix: asset source resolver typo (facebook#34520)
61dd151 
Summary:
Small typo fix.

## Changelog

[General] [Fixed] - Typo in AssetSourceResolver

Pull Request resolved: facebook#34520

Test Plan: No test plan is required. Just check the file changes.

Reviewed By: NickGerleman

Differential Revision: D39087572

Pulled By: cipolleschi

fbshipit-source-id: a79253d2486ee21fbf5683177b21ec534607d65d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhruvtailor7 @analysis-bot @facebook-github-bot @react-native-bot