Use verdaccio for the template e2e test #34577

fortmarek · 2022-09-02T10:00:49Z

Summary

This PR adds verdaccio to release packages in the packages directory during the E2E test on CI.

The rationale behind this is the following:

Firstly, we wanted to push the monorepo RFC. We hit an issue when renaming the packages to follow the same convention caused by the e2e test using the template to fail. This is because the template installs packages from the live version of npm – and if you just rename a package in a given PR without releasing it, the package understandably can't be installed since it's not published, yet – as you can see here.
Secondly, the current e2e test on main does not actually test the latest code of the packages in the packages directory as it simply downloads the latest versions from npm. This creates a divide between what's tested and what users should expect when using nightlies or when a new minor is released.

Changelog

[Internal] [Changed] - Use verdaccio for template e2e test

Test Plan

test_js CI check should pass. Additionally, I have temporarily updated the PR renaming assets to assets-registry to include the verdaccio changes – the test_js passes there, additionally proving merging this PR will unblock us with the rename PRs.

analysis-bot · 2022-09-02T11:11:41Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 6529383
Branch: main

analysis-bot · 2022-09-02T11:11:55Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,698,673	+0
android	hermes	armeabi-v7a	7,102,261	+0
android	hermes	x86	8,001,419	+0
android	hermes	x86_64	7,973,988	+0
android	jsc	arm64-v8a	9,569,410	+0
android	jsc	armeabi-v7a	8,336,421	+0
android	jsc	x86	9,509,836	+0
android	jsc	x86_64	10,101,516	+0

Base commit: 6529383
Branch: main

oblador · 2022-09-08T12:06:39Z

scripts/run-ci-e2e-tests.js

@@ -70,6 +72,25 @@ try {

  const REACT_NATIVE_PACKAGE = path.join(ROOT, 'react-native-*.tgz');

+  describe('Verdaccio');
+  const verdaccioProcess = child_process.spawn('npx', [
+    'verdaccio',


I didn't see this added to dependencies, so I think we want to lock the version somehow, you can do it like this:

Suggested change

'verdaccio',

'verdaccio@5.15.3',

oblador · 2022-09-08T12:08:35Z

scripts/run-ci-e2e-tests.js

+      'yarn',
+      ['start', '--max-workers 1'],
+      {
+        env: process.env,


This is the default, so you can delete these options afaik

juanpicado · 2022-09-13T06:54:51Z

.circleci/verdaccio/config.yml

+      keepAlive: true
+      maxSockets: 40
+      maxFreeSockets: 10
+packages:


I'd recommend optimisations like facebook/docusaurus#7967 to avoid the registry proxy private packages to outside (publish might fails due network conditions) also help to keep isolated the packages.

This is perfect, thank you so much 🤞

juanpicado · 2022-09-13T06:56:09Z

.circleci/verdaccio/config.yml

+    publish: $all
+    proxy: npmjs
+logs:
+  - {type: file, path: verdaccio.log, format: pretty, level: debug}


Debug is really verbose, I'd recommend warn and also pretty is pretty expensive in terms of execution, if you don't need the coolers or fancy arrows, you might consider json instead to boost the registry.

template/package.json

cortinico · 2022-09-14T16:47:09Z

Thanks for doing this @fortmarek. I haven't had the time to review this yet, but I've posted an update on the Monorepo effort here: #34692 so we're aligned on the next steps

cortinico

Great stuff 👍

scripts/run-ci-e2e-tests.js

.circleci/verdaccio.yml

cortinico · 2022-09-20T18:31:05Z

.circleci/verdaccio.yml

+  '@*/*':
+    access: $all
+    publish: $authenticated
+    proxy: npmjs


Why is this needed?

This prohibits unauthenticated users to published organization-scoped packages. I've seen this being done both in the Microsoft PR and the docusaurus one. @juanpicado, do you know the exact reasoning behind this?

Great thanks for the clarification 👍

fortmarek · 2022-09-22T06:30:53Z

Thanks for the review, the comments have been addressed 🤞

facebook-github-bot · 2022-09-22T07:50:09Z

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

react-native-bot · 2022-09-22T12:05:05Z

This pull request was successfully merged by @fortmarek in 22940e4.

^{When will my fix make it into a release? | Upcoming Releases}

Summary: This PR adds [verdaccio](https://github.com/verdaccio/verdaccio) to release packages in the `packages` directory during the E2E test on CI. The rationale behind this is the following: - Firstly, we wanted to push the [monorepo RFC](react-native-community/discussions-and-proposals#480). We hit an issue when renaming the packages to follow the same convention caused by the e2e test using the template to fail. This is because the template installs packages from the live version of npm – and if you just rename a package in a given PR without releasing it, the package understandably can't be installed since it's not published, yet – as you can see [here](https://app.circleci.com/pipelines/github/facebook/react-native/15286/workflows/149df51f-f59b-4eb3-b92c-20c513111f04/jobs/282135?invite=true#step-108-283). - Secondly, the current e2e test on `main` does not actually test the latest code of the packages in the `packages` directory as it simply downloads the latest versions from npm. This creates a divide between what's tested and what users should expect when using nightlies or when a new minor is released. ## Changelog  [Internal] [Changed] - Use verdaccio for template e2e test Pull Request resolved: facebook#34577 Test Plan: `test_js` CI check should pass. Additionally, I have temporarily updated the [PR](facebook#34572) renaming `assets` to `assets-registry` to include the verdaccio changes – the `test_js` passes there, additionally proving merging this PR will unblock us with the rename PRs. Reviewed By: cipolleschi Differential Revision: D39723048 Pulled By: cortinico fbshipit-source-id: aeff3811967360740df3b3dbf1df50e506fb72d8

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Shopify Partner: Shopify Partner labels Sep 2, 2022

fortmarek force-pushed the verdaccio branch 4 times, most recently from d10087b to f078bb1 Compare September 2, 2022 10:48

fortmarek force-pushed the verdaccio branch 19 times, most recently from 83a5efe to 73c56c8 Compare September 6, 2022 20:47

oblador reviewed Sep 8, 2022

View reviewed changes

fortmarek requested a review from oblador September 12, 2022 20:29

fortmarek changed the title ~~Verdaccio~~ Use verdaccio for the template e2e test Sep 12, 2022

juanpicado reviewed Sep 13, 2022

View reviewed changes

fortmarek force-pushed the verdaccio branch from 7621118 to c97a465 Compare September 14, 2022 13:14

fortmarek commented Sep 14, 2022

View reviewed changes

template/package.json Show resolved Hide resolved

fortmarek force-pushed the verdaccio branch from c97a465 to 64ee397 Compare September 14, 2022 13:21

fortmarek requested review from juanpicado and removed request for oblador September 14, 2022 13:21

cortinico mentioned this pull request Sep 14, 2022

☂️ React Native Monorepo #34692

Closed

11 tasks

cortinico approved these changes Sep 20, 2022

View reviewed changes

fortmarek force-pushed the verdaccio branch 4 times, most recently from ec56dd1 to e2f3ac0 Compare September 21, 2022 20:31

fortmarek added 2 commits September 21, 2022 22:35

Add verdaccio

d0f7305

Improve verdaccio setup

80bb93d

fortmarek force-pushed the verdaccio branch 2 times, most recently from d82ef32 to 9e2f6e6 Compare September 21, 2022 20:38

Address PR comments

6fafd7a

fortmarek force-pushed the verdaccio branch from 9e2f6e6 to 6fafd7a Compare September 21, 2022 20:43

facebook-github-bot closed this in 22940e4 Sep 22, 2022

react-native-bot added the Merged This PR has been merged. label Sep 22, 2022

cortinico mentioned this pull request Oct 14, 2022

chore: renamed react-native-codegen to @react-native/codegen #34804

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use verdaccio for the template e2e test #34577

Use verdaccio for the template e2e test #34577

fortmarek commented Sep 2, 2022 •

edited

Loading

analysis-bot commented Sep 2, 2022 •

edited

Loading

analysis-bot commented Sep 2, 2022 •

edited

Loading

oblador Sep 8, 2022

oblador Sep 8, 2022

juanpicado Sep 13, 2022

fortmarek Sep 14, 2022

juanpicado Sep 13, 2022

cortinico commented Sep 14, 2022

cortinico left a comment

cortinico Sep 20, 2022

fortmarek Sep 21, 2022

cortinico Sep 22, 2022

fortmarek commented Sep 22, 2022

facebook-github-bot commented Sep 22, 2022

react-native-bot commented Sep 22, 2022

Use verdaccio for the template e2e test #34577

Use verdaccio for the template e2e test #34577

Conversation

fortmarek commented Sep 2, 2022 • edited Loading

Summary

Changelog

Test Plan

analysis-bot commented Sep 2, 2022 • edited Loading

analysis-bot commented Sep 2, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cortinico commented Sep 14, 2022

cortinico left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fortmarek commented Sep 22, 2022

facebook-github-bot commented Sep 22, 2022

react-native-bot commented Sep 22, 2022

fortmarek commented Sep 2, 2022 •

edited

Loading

analysis-bot commented Sep 2, 2022 •

edited

Loading

analysis-bot commented Sep 2, 2022 •

edited

Loading