Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor react-native-codegen into packages/codegen #34578

Closed
wants to merge 3 commits into from
Closed

chore: refactor react-native-codegen into packages/codegen #34578

wants to merge 3 commits into from

Conversation

shivenmian
Copy link
Contributor

Summary

Renaming packages/react-native-codegen folder to packages/codegen and updating references; part of RFC480

Changelog

[General] [Changed] - Renamed packages/react-native-codegen to packages/codegen and updated references.

Test Plan

@shivenmian shivenmian requested a review from hramos as a code owner September 2, 2022 10:17
@facebook-github-bot
Copy link
Contributor

Hi @shivenmian!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

tido64
tido64 requested changes Sep 2, 2022
View reviewed changes
Copy link
Collaborator

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files lost their executable bit. They are marked as 100755 → 100644. Can we restore them?

@shivenmian
Copy link
Contributor Author

shivenmian commented Sep 2, 2022 •
edited
Loading

@tido64 @cortinico done

tido64
tido64 approved these changes Sep 2, 2022
View reviewed changes
Copy link
Collaborator

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to remove the "requested changes" tag:

image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 2, 2022
@facebook-github-bot
Copy link
Contributor

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cortinico cortinico added the Tech: Monorepo For PRs that are related to the monorepo infra label Sep 12, 2022
@kelset kelset added p: Microsoft Partner: Microsoft Partner labels Sep 12, 2022
@cortinico cortinico mentioned this pull request Sep 14, 2022
Closed
11 tasks
cortinico
cortinico reviewed Sep 15, 2022
View reviewed changes
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this over @shivenmian

Let's undo the folder renaming. It will make easier for us to import and merge this change 👍

I've also posted an update on the monorepo effort there:

@shivenmian
Copy link
Contributor Author

@cortinico This PR mostly just does the folder renaming and corrects the references accordingly - I was going to send a separate PR for the actual package renaming as we had discussed. Should I close this PR then?

@cortinico
Copy link
Contributor

@cortinico This PR mostly just does the folder renaming and corrects the references accordingly - I was going to send a separate PR for the actual package renaming as we had discussed. Should I close this PR then?

Yeah it's better to close this off and send a new one with just the package renaming 👍

@shivenmian shivenmian closed this Sep 27, 2022
@shivenmian shivenmian mentioned this pull request Sep 27, 2022
Closed
@shivenmian
Copy link
Contributor Author

@cortinico closed this one and opened #34804

@shivenmian shivenmian deleted the rn_codegen_refactor branch September 28, 2022 16:37
facebook-github-bot pushed a commit that referenced this pull request Nov 28, 2022
@shivenmian @facebook-github-bot
chore: renamed react-native-codegen to @react-native/codegen (#34804)
b7a85b5 
Summary:
Renamed react-native-codegen package to react-native/codegen and updated references, without changing the folder name; part of RFC480 (#34692). Follow-up from #34578

## Changelog

[General] [Changed] - Renamed react-native-codegen package to react-native/codegen and updated references

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

Pull Request resolved: #34804

Reviewed By: cortinico

Differential Revision: D39883584

Pulled By: hoxyq

fbshipit-source-id: 0ef384b75c6edd248b31e37b8f05f64b4d39ca6f
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@shivenmian @OlimpiaZurek
chore: renamed react-native-codegen to @react-native/codegen (faceboo…
f7040fc 
…k#34804)

Summary:
Renamed react-native-codegen package to react-native/codegen and updated references, without changing the folder name; part of RFC480 (facebook#34692). Follow-up from facebook#34578

## Changelog

[General] [Changed] - Renamed react-native-codegen package to react-native/codegen and updated references

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

Pull Request resolved: facebook#34804

Reviewed By: cortinico

Differential Revision: D39883584

Pulled By: hoxyq

fbshipit-source-id: 0ef384b75c6edd248b31e37b8f05f64b4d39ca6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico left review comments

@tido64 tido64 tido64 approved these changes

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Tech: Monorepo For PRs that are related to the monorepo infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shivenmian @facebook-github-bot @cortinico @tido64 @kelset