Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/fontweight number value #34598

Closed

Conversation

ankit-tailor
Copy link
Contributor

Summary

This PR adds support for number values for fontWeight as requested in #34425.

Changelog

[General] [Added] - Added support for number values in fontWeight.

Test Plan

<Text style={{ fontWeight: 900, color: 'red' }}>
  Hello World
</Text>

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 5, 2022
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Sep 5, 2022
@analysis-bot
Copy link

analysis-bot commented Sep 5, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 4f6929b
Branch: main

@analysis-bot
Copy link

analysis-bot commented Sep 5, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,638,097 +1,062
android hermes armeabi-v7a 7,050,075 +841
android hermes x86 7,940,060 +1,222
android hermes x86_64 7,912,080 +1,309
android jsc arm64-v8a 9,513,807 +978
android jsc armeabi-v7a 8,289,094 +760
android jsc x86 9,453,350 +1,135
android jsc x86_64 10,044,592 +1,229

Base commit: 4f6929b
Branch: main

Libraries/Text/Text.js Outdated Show resolved Hide resolved
@ankit-tailor ankit-tailor requested a review from necolas September 6, 2022 02:50
@necolas
Copy link
Contributor

necolas commented Sep 6, 2022

Are there any existing unit tests that we can expand to include this change?

@ankit-tailor
Copy link
Contributor Author

No, I couldn't find any existing tests.

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Libraries/Text/Text.js Outdated Show resolved Hide resolved
Co-authored-by: Fedir Ushakov <pmahotsava@gmail.com>
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @ankit-tailor in f1c1f81.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 12, 2022
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
This PR adds support for number values for `fontWeight` as requested in facebook#34425.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[General] [Added] - Added support for number values in fontWeight.

Pull Request resolved: facebook#34598

Test Plan:
```js
<Text style={{ fontWeight: 900, color: 'red' }}>
  Hello World
</Text>
```

Reviewed By: jacdebug

Differential Revision: D39268920

Pulled By: cipolleschi

fbshipit-source-id: 9bb711677bf173f9904b74f382659042856efd83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants