-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/fontweight number value #34598
Feat/fontweight number value #34598
Conversation
Base commit: 4f6929b |
Base commit: 4f6929b |
Are there any existing unit tests that we can expand to include this change? |
No, I couldn't find any existing tests. |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Co-authored-by: Fedir Ushakov <pmahotsava@gmail.com>
This pull request was successfully merged by @ankit-tailor in f1c1f81. When will my fix make it into a release? | Upcoming Releases |
Summary: This PR adds support for number values for `fontWeight` as requested in facebook#34425. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General] [Added] - Added support for number values in fontWeight. Pull Request resolved: facebook#34598 Test Plan: ```js <Text style={{ fontWeight: 900, color: 'red' }}> Hello World </Text> ``` Reviewed By: jacdebug Differential Revision: D39268920 Pulled By: cipolleschi fbshipit-source-id: 9bb711677bf173f9904b74f382659042856efd83
Summary
This PR adds support for number values for
fontWeight
as requested in #34425.Changelog
[General] [Added] - Added support for number values in fontWeight.
Test Plan