Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#34610 Fix invalid range "t-5" in string transliteration [iOS] #34636

Closed
wants to merge 2 commits into from
Closed

#34610 Fix invalid range "t-5" in string transliteration [iOS] #34636

wants to merge 2 commits into from

Conversation

Romick2005
Copy link
Contributor

@Romick2005 Romick2005 commented Sep 8, 2022 •
edited
Loading

Fix invalid range "t-5" in string transliteration [iOS] for M1 pod install issue.

Summary

This should fix pod install error for M1 machines.

Changelog

[iOS] [Fixed] - Fix ios pod install error

Test Plan

Run pod install on M1 machine.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 8, 2022
@Romick2005 Romick2005 mentioned this pull request Sep 8, 2022
Closed
@react-native-bot react-native-bot added Bug Platform: iOS iOS applications. labels Sep 8, 2022
@analysis-bot
Copy link

analysis-bot commented Sep 8, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,639,580 -2,293
android hermes armeabi-v7a 7,051,693 -2,527
android hermes x86 7,941,121 -2,540
android hermes x86_64 7,913,223 -2,329
android jsc arm64-v8a 9,513,356 -2,130
android jsc armeabi-v7a 8,288,966 -2,130
android jsc x86 9,452,684 -2,133
android jsc x86_64 10,043,750 -2,140

Base commit: 9788db0
Branch: main

cipolleschi
cipolleschi requested changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Romick2005, thanks for fixing this issue. I left a comment with a suggestion to improve readability.
Please, update also the tests.

scripts/cocoapods/utils.rb Outdated Show resolved Hide resolved
@Romick2005
Copy link
Contributor Author

Hi @Romick2005, thanks for fixing this issue. I left a comment with a suggestion to improve readability. Please, update also the tests.

Hi @cipolleschi, thank you for review! Done some changes to make you happier!

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 624bdc7
Branch: main

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Romick2005 in 0cae495.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 13, 2022
dmytrorykun pushed a commit that referenced this pull request Sep 14, 2022
@Romick2005
#34610 Fix invalid range "t-5" in string transliteration [iOS] (#34636)
eaa32f9 
Summary:
Fix invalid range "t-5" in string transliteration [iOS] for M1 pod install issue.

This should fix pod install error for M1 machines.

## Changelog
[iOS] [Fixed] - Fix ios pod install error

Pull Request resolved: #34636

Test Plan: Run pod install on M1 machine.

Reviewed By: sammy-SC

Differential Revision: D39423276

Pulled By: cipolleschi

fbshipit-source-id: 4ec95af7103395792facba0f93fd8de05a3fe78d
@snyk-bot snyk-bot mentioned this pull request Oct 11, 2022
Open
@NOUIY NOUIY mentioned this pull request Oct 25, 2022
Open
@NOUIY NOUIY mentioned this pull request Nov 3, 2022
Open
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@Romick2005 @OlimpiaZurek
facebook#34610 Fix invalid range "t-5" in string transliteration [iOS] (
5d48410 
facebook#34636)

Summary:
Fix invalid range "t-5" in string transliteration [iOS] for M1 pod install issue.

This should fix pod install error for M1 machines.

## Changelog
[iOS] [Fixed] - Fix ios pod install error

Pull Request resolved: facebook#34636

Test Plan: Run pod install on M1 machine.

Reviewed By: sammy-SC

Differential Revision: D39423276

Pulled By: cipolleschi

fbshipit-source-id: 4ec95af7103395792facba0f93fd8de05a3fe78d
@cipolleschi cipolleschi mentioned this pull request Nov 1, 2023
Closed
@cipolleschi cipolleschi mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees
No one assigned
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: iOS iOS applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Romick2005 @analysis-bot @facebook-github-bot @react-native-bot @cipolleschi