-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HERMES_ENABLED check in scripts/react-native-xcode.sh #34675
Fix HERMES_ENABLED check in scripts/react-native-xcode.sh #34675
Conversation
Hi @nvojnovic! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @nvojnovic in 8745a14. When will my fix make it into a release? | Upcoming Releases |
…4675) Summary: Checking if Hermes is enabled is failing because there is no `podfile.lock` file in the directory where this script is executed and `USE_HERMES` will be set to `false` which will prevent building Hermes binary jsbundle. ## Changelog [iOS] [Fixed] - `HERMES_ENABLED` check fixed in react-native-xcode.sh Pull Request resolved: facebook#34675 Test Plan: 1. Enable Hermes 2. Make a release build 3. Verify the `main.jsbundle` file is Hermes binary bundle Reviewed By: cortinico Differential Revision: D39686608 Pulled By: cipolleschi fbshipit-source-id: 237c77ced484d4ab77e576c7a2bb7b6826228017
Summary
Checking if Hermes is enabled is failing because there is no
podfile.lock
file in the directory where this script is executed andUSE_HERMES
will be set tofalse
which will prevent building Hermes binary jsbundle.Changelog
[iOS] [Fixed] -
HERMES_ENABLED
check fixed in react-native-xcode.shTest Plan
main.jsbundle
file is Hermes binary bundle