chore: Extract codegen ParserError from flow and typescript into a common file #34874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: ae3dd54 |
Base commit: ae3dd54 |
|
@hramos has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
approved these changes
Oct 6, 2022
cortinico
approved these changes
Oct 6, 2022
|
I'm sorry, we are landing some changes and these introduced some conflicts. Could you rebase and fix them, please? 🙏 |
gabrieldonadel
force-pushed
the
chore/extract-codegen-parser-error
branch
from
261a7bc
to
3c05118
Compare
Sure @cipolleschi, no problem |
|
/rebase |
github-actions
bot
force-pushed
the
chore/extract-codegen-parser-error
branch
from
3c05118
to
ffef1c5
Compare
|
@hramos could you reimport this? 🙏 |
|
@hramos has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @gabrieldonadel in 7227bde. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…mmon file (facebook#34874) Summary: This PR extracts the `ParserError` class from the `error.js` files from the flow and typescript folders into a single file in their parent folder in order to reduce the amount of duplicated code as requested on facebook#34872 ## Changelog [Internal] [Changed] - Extract codegen `ParserError` from flow and typescript folders into a common file Pull Request resolved: facebook#34874 Test Plan: Run `yarn jest react-native-codegen` and ensure CI is green  Reviewed By: cipolleschi Differential Revision: D40133301 Pulled By: cipolleschi fbshipit-source-id: 060571cf993672a9d03003e1a1a7c2aa2f381123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR extracts the
ParserErrorclass from theerror.jsfiles from the flow and typescript folders into a single file in their parent folder in order to reduce the amount of duplicated code as requested on #34872Changelog
[Internal] [Changed] - Extract codegen
ParserErrorfrom flow and typescript folders into a common fileTest Plan
Run
yarn jest react-native-codegenand ensure CI is green