-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make RCTBlobManager TurboModule-compatible #35047
Conversation
Base commit: 48db6be |
Base commit: fd91748 |
PR build artifact for 1964d07 is ready. |
PR build artifact for 1964d07 is ready. |
@RSNara can you review this one? |
Done. Thanks. |
/rebase |
1964d07
to
6269a1e
Compare
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
PR build artifact for 6269a1e is ready. |
PR build artifact for 6269a1e is ready. |
This pull request was successfully merged by @andrestone in 279cfec. When will my fix make it into a release? | Upcoming Releases |
Hi! In the context of cutting the branch for 0.71.0-rc0, we had to revert this commit in #35188, for 2 reasons:
We will look into this thing before releasing 0.71 to make sure that the RCTBlobManager works properly! |
Summary: This diff reverts D40716048 (facebook@279cfec) (facebook#35047) which breaks RCTImageLoader. https://pxl.cl/2jKrM Those files are auto-generated and are not supposed to be edited manually. Changelog: [iOS] [Fixed] - facebook#35047 reverted. Reviewed By: cipolleschi Differential Revision: D40979350 fbshipit-source-id: ece2b9c653fe01e209a523e6a99e41a0605fddac
Summary: Pull Request resolved: #35188 This diff reverts D40716048 (279cfec) (#35047) which breaks RCTImageLoader. https://pxl.cl/2jKrM Those files are auto-generated and are not supposed to be edited manually. Changelog: [iOS] [Fixed] - #35047 reverted. Reviewed By: cipolleschi Differential Revision: D40979350 fbshipit-source-id: ef92cf05636cba818151d4184e0275a3aab56cff
Summary: Currently, RCTBlobManager (the native module for Blob support) cannot be loaded on iOS when the new architecture is enabled. ## Changelog [General] [Added] - `BlobModule` to `RCTCoreModulesClassProvider` Pull Request resolved: facebook#35047 Test Plan: The snippet below can be used to test Blob support with the new architecture enabled. ``` // App.tsx import { useEffect } from 'react'; import { View } from 'react-native'; function uriToBlob(uri: any) { return new Promise((resolve, reject) => { const xhr = new XMLHttpRequest(); xhr.responseType = 'blob'; xhr.onload = () => { const blob = xhr.response; resolve(blob); }; xhr.onerror = err => { reject(err); }; xhr.open('GET', uri); xhr.send(); }); } export default function App() { useEffect(() => { uriToBlob('https://www.google.com/images/branding/googlelogo/1x/googlelogo_color_272x92dp.png'); }); return <View />; } ``` Related issue: facebook#35042 Reviewed By: NickGerleman Differential Revision: D40716048 Pulled By: cipolleschi fbshipit-source-id: 17643d230fa7ea83baee363d137d51f87818baa8
Summary: Pull Request resolved: facebook#35188 This diff reverts D40716048 (facebook@279cfec) (facebook#35047) which breaks RCTImageLoader. https://pxl.cl/2jKrM Those files are auto-generated and are not supposed to be edited manually. Changelog: [iOS] [Fixed] - facebook#35047 reverted. Reviewed By: cipolleschi Differential Revision: D40979350 fbshipit-source-id: ef92cf05636cba818151d4184e0275a3aab56cff
Summary
Currently, RCTBlobManager (the native module for Blob support) cannot be loaded on iOS when the new architecture is enabled.
Changelog
[General] [Added] -
BlobModule
toRCTCoreModulesClassProvider
Test Plan
The snippet below can be used to test Blob support with the new architecture enabled.
Related issue: #35042