Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enum example to Android/iOS rn-tester TurboModule #35133

Closed

Conversation

christophpurrer
Copy link
Contributor

Summary:
Add enum example to Android/iOS rn-tester TurboModule

Changelog:
[General][Added] - Add enum example to Android/iOS rn-tester TurboModule

Differential Revision: D40711269

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Oct 30, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40711269

@github-actions
Copy link

github-actions bot commented Oct 30, 2022

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against b3562f2

@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Oct 30, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40711269

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 30, 2022
Summary:
Pull Request resolved: facebook#35133

Add enum example to Android/iOS rn-tester TurboModule

Changelog:
[General][Added] - Add enum example to Android/iOS rn-tester TurboModule

Differential Revision: D40711269

fbshipit-source-id: 8814b5be3b3a55ef8965a97cf5318975cc9f1613
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40711269

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 31, 2022
Summary:
Pull Request resolved: facebook#35133

Add enum example to Android/iOS rn-tester TurboModule

Changelog:
[General][Added] - Add enum example to Android/iOS rn-tester TurboModule

Differential Revision: D40711269

fbshipit-source-id: 03017b3aec9685c32b0bd532a1b4d43261e98378
@analysis-bot
Copy link

analysis-bot commented Oct 31, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 1b1b26a
Branch: main

@pull-bot
Copy link

PR build artifact for e8e4ab0 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40711269

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 31, 2022
Summary:
Pull Request resolved: facebook#35133

Add enum example to Android/iOS rn-tester TurboModule

Changelog:
[General][Added] - Add enum example to Android/iOS rn-tester TurboModule

Differential Revision: D40711269

fbshipit-source-id: b30713a67e80110804024408badb7d69290f4be9
@pull-bot
Copy link

PR build artifact for 977132c is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40711269

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 3, 2022
Summary:
Pull Request resolved: facebook#35133

Add enum example to Android/iOS rn-tester TurboModule

Changelog:
[General][Added] - Add enum example to Android/iOS rn-tester TurboModule

Differential Revision: D40711269

fbshipit-source-id: 43c2cf3ffdd0cfa3a61ecbb637c4e241c38884b6
@analysis-bot
Copy link

analysis-bot commented Nov 3, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,101,430 +831
android hermes armeabi-v7a 6,470,772 +769
android hermes x86 7,518,920 +837
android hermes x86_64 7,377,801 +848
android jsc arm64-v8a 8,965,378 +636
android jsc armeabi-v7a 7,696,702 +571
android jsc x86 9,027,879 +647
android jsc x86_64 9,506,032 +658

Base commit: 1b1b26a
Branch: main

@pull-bot
Copy link

pull-bot commented Nov 3, 2022

PR build artifact for bc2ac20 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 3, 2022
Summary:
Pull Request resolved: facebook#35133

Add enum example to Android/iOS rn-tester TurboModule

Changelog:
[General][Added] - Add enum example to Android/iOS rn-tester TurboModule

Differential Revision: D40711269

fbshipit-source-id: eec09f06b22b46fcb75b8f2ad5e5652bfcbcd242
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40711269

@pull-bot
Copy link

pull-bot commented Nov 4, 2022

PR build artifact for b49a5f1 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40711269

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40711269

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 10, 2022
Summary:
Pull Request resolved: facebook#35133

Add enum example to Android/iOS rn-tester TurboModule

Changelog:
[General][Added] - Add enum example to Android/iOS rn-tester TurboModule

Differential Revision: D40711269

fbshipit-source-id: 645f9c7ce3c307cf46000e32f7c35d90e8f686c9
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40711269

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 10, 2022
Summary:
Pull Request resolved: facebook#35133

Add enum example to Android/iOS rn-tester TurboModule

Changelog:
[General][Added] - Add enum example to Android/iOS rn-tester TurboModule

Differential Revision: D40711269

fbshipit-source-id: ebaea8fa150cce50b5a85e8789ae05242ac47311
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40711269

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 10, 2022
Summary:
Pull Request resolved: facebook#35133

Add enum example to Android/iOS rn-tester TurboModule

Changelog:
[General][Added] - Add enum example to Android/iOS rn-tester TurboModule

Differential Revision: D40711269

fbshipit-source-id: 9d2aeaedb7b75462b1c4f945c289f5ef5c1a6ac8
@pull-bot
Copy link

PR build artifact for 5f45dbe is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40711269

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 10, 2022
Summary:
Pull Request resolved: facebook#35133

Add enum example to Android/iOS rn-tester TurboModule

Changelog:
[General][Added] - Add enum example to Android/iOS rn-tester TurboModule

Differential Revision: D40711269

fbshipit-source-id: 00e25e8d9f008983d96aaeee1e66e06a1191f592
@pull-bot
Copy link

PR build artifact for b2f0640 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

Summary:
Pull Request resolved: facebook#35133

Add enum example to Android/iOS rn-tester TurboModule

Changelog:
[General][Added] - Add enum example to Android/iOS rn-tester TurboModule

Differential Revision: D40711269

fbshipit-source-id: 28ea1b22a6a4043306fa458f74b861a96dc4dcf2
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40711269

@pull-bot
Copy link

PR build artifact for b3562f2 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Feb 2, 2023
Summary:
Pull Request resolved: facebook#35133

Add enum example to Android/iOS rn-tester TurboModule

Changelog:
[General][Added] - Add enum example to Android/iOS rn-tester TurboModule

Reviewed By: javache

Differential Revision: D40711269

fbshipit-source-id: 4fb1be87072af62ad03c5cd5592343e7d0ce8ee0
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40711269

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40711269

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Feb 3, 2023
Summary:
Pull Request resolved: facebook#35133

Add enum example to Android/iOS rn-tester TurboModule

Changelog:
[General][Added] - Add enum example to Android/iOS rn-tester TurboModule

Reviewed By: javache

Differential Revision: D40711269

fbshipit-source-id: 382401e32c745f0f7090aa4817751a1d96976128
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Feb 3, 2023
Summary:
Pull Request resolved: facebook#35133

Add enum example to Android/iOS rn-tester TurboModule

Changelog:
[General][Added] - Add enum example to Android/iOS rn-tester TurboModule

Reviewed By: javache

Differential Revision: D40711269

fbshipit-source-id: 0292fae6e58c249db3ae8c304b64af97729e7059
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40711269

facebook-github-bot pushed a commit that referenced this pull request Feb 9, 2023
Summary:
Pull Request resolved: #35133

Add enum example to Android/iOS rn-tester TurboModule

Changelog:
[General][Added] - Add enum example to Android/iOS rn-tester TurboModule

Reviewed By: javache, cipolleschi

Differential Revision: D40711269

fbshipit-source-id: c8ad6fb7dee40b45b696660cc4d78921edafd8a1
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

This pull request was successfully merged by @christophpurrer in 7c82a3f.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Feb 9, 2023
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#35133

Add enum example to Android/iOS rn-tester TurboModule

Changelog:
[General][Added] - Add enum example to Android/iOS rn-tester TurboModule

Reviewed By: javache, cipolleschi

Differential Revision: D40711269

fbshipit-source-id: c8ad6fb7dee40b45b696660cc4d78921edafd8a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants