Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buck, etc. changes that enable persisted, sync settings for DevTools #35163

Closed
wants to merge 1 commit into from

Conversation

rbalicki2
Copy link
Contributor

@rbalicki2 rbalicki2 commented Nov 1, 2022

Summary:

What

This diff contains all the changes from D40333083 (0fac981) (aka #34964), except the change to setUpReactDevTools.js, which actually uses the new files.

Why

  • We want to ship the Buck, C++, etc. changes before the JavaScript changes that depend on those files.
  • Otherwise, apps can fail at startup with the message:
`TurboModuleRegistry.getEnforcing(...): '${name}' could not be found. ` +
      'Verify that a module by this name is registered in the native binary.',
  • Note that this only occurs if you are using a previously-built version of the C++, Obj C, etc. files in RN, but a more recent version of the JavaScript files. If you are building from matching sources, this does not occur.
  • After a few days, we can land the JS files.

Changelog

[General][Added] Add, but don't use, DevTools Settings Manager.

Differential Revision: D40873390

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 1, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40873390

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40873390

rbalicki2 pushed a commit to rbalicki2/react-native that referenced this pull request Nov 1, 2022
…acebook#35163)

Summary:
Pull Request resolved: facebook#35163

# What

This diff contains all the changes from D40333083 (facebook@0fac981) (aka facebook#34964), **except** the change to `setUpReactDevTools.js`, which actually uses the new files.

# Why

* We want to ship the Buck, C++, etc. changes before the JavaScript changes that depend on those files.
* Otherwise, apps can fail at startup with the message:
```
`TurboModuleRegistry.getEnforcing(...): '${name}' could not be found. ` +
      'Verify that a module by this name is registered in the native binary.',
```
* Note that this only occurs if you are using a previously-built version of the C++, Obj C, etc. files in RN, but a more recent version of the JavaScript files. If you are building from matching sources, this does not occur.
* After a few days, we can land the JS files.

## Changelog
[General][Added] Add, but don't use, DevTools Settings Manager.

Differential Revision: D40873390

fbshipit-source-id: 510fa3accb2a9037cd365adad6ba0c9d87d360a8
…acebook#35163)

Summary:
Pull Request resolved: facebook#35163

# What

This diff contains all the changes from D40333083 (facebook@0fac981) (aka facebook#34964), **except** the change to `setUpReactDevTools.js`, which actually uses the new files.

# Why

* We want to ship the Buck, C++, etc. changes before the JavaScript changes that depend on those files.
* Otherwise, apps can fail at startup with the message:
```
`TurboModuleRegistry.getEnforcing(...): '${name}' could not be found. ` +
      'Verify that a module by this name is registered in the native binary.',
```
* Note that this only occurs if you are using a previously-built version of the C++, Obj C, etc. files in RN, but a more recent version of the JavaScript files. If you are building from matching sources, this does not occur.
* After a few days, we can land the JS files.

## Changelog
[General][Added] Add, but don't use, DevTools Settings Manager.

Differential Revision: D40873390

fbshipit-source-id: 4d401f7d0e5051eb25ed984d814d8effd9ad2915
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40873390

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,993,360 +1,800
android hermes armeabi-v7a 6,369,315 +1,219
android hermes x86 7,405,777 +1,532
android hermes x86_64 7,269,718 +1,462
android jsc arm64-v8a 8,857,371 +2,054
android jsc armeabi-v7a 7,595,300 +1,475
android jsc x86 8,914,840 +1,773
android jsc x86_64 9,398,128 +1,714

Base commit: 40ad31e
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 40ad31e
Branch: main

@pull-bot
Copy link

pull-bot commented Nov 1, 2022

PR build artifact for b89a856 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

pull-bot commented Nov 1, 2022

PR build artifact for b89a856 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by Robert Balicki in 6152763.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 7, 2022
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
…acebook#35163)

Summary:
Pull Request resolved: facebook#35163

# What

This diff contains all the changes from D40333083 (facebook@0fac981) (aka facebook#34964), **except** the change to `setUpReactDevTools.js`, which actually uses the new files.

# Why

* We want to ship the Buck, C++, etc. changes before the JavaScript changes that depend on those files.
* Otherwise, apps can fail at startup with the message:
```
`TurboModuleRegistry.getEnforcing(...): '${name}' could not be found. ` +
      'Verify that a module by this name is registered in the native binary.',
```
* Note that this only occurs if you are using a previously-built version of the C++, Obj C, etc. files in RN, but a more recent version of the JavaScript files. If you are building from matching sources, this does not occur.
* After a few days, we can land the JS files.

## Changelog

Changelog
[General][Added] Add, but don't use, DevTools Settings Manager.

Reviewed By: NickGerleman

Differential Revision: D40873390

fbshipit-source-id: c7bac6ae65f85666b8616443db278ebb175b691b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants