Do not use InteractionManager to wait for Activity #35289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D41157646 |
Base commit: 5744b21 |
Summary: Pull Request resolved: facebook#35289 This was originally added in D15258046 (facebook@c802d0b) but seems to be the wrong solution to the problem from my perspective. InteractionManager does not provide timing information on the activity being available, but ReactContext's LifecycleEventListener does. This should also address some of the issues raised in facebook#25675 Changelog: [Android][Fixed] Linking.getInitialUrl should not wait for InteractionManager Differential Revision: D41157646 fbshipit-source-id: 610ee440c38cb6e5b7e0b8d808e0e2e73599404c
|
This pull request was exported from Phabricator. Differential Revision: D41157646 |
javache
force-pushed
the
export-D41157646
branch
from
e82ba85
to
69d87d8
Compare
Base commit: 5744b21 |
|
PR build artifact for 69d87d8 is ready. |
|
PR build artifact for 69d87d8 is ready. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#35289 This was originally added in D15258046 (facebook@c802d0b) but seems to be the wrong solution to the problem from my perspective. InteractionManager does not provide timing information on the activity being available, but ReactContext's LifecycleEventListener does. This should also address some of the issues raised in facebook#25675 Changelog: [Android][Fixed] Linking.getInitialUrl should not wait for InteractionManager Reviewed By: mdvacca Differential Revision: D41157646 fbshipit-source-id: 6e23969212570204a7e076b6d4d9db004412da09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This was originally added in D15258046 (c802d0b) but seems to be the wrong solution to the problem from my perspective. InteractionManager does not provide timing information on the activity being available, but ReactContext's LifecycleEventListener does.
This should also address some of the issues raised in #25675
Changelog: [Android][Fixed] Linking.getInitialUrl should not wait for InteractionManager
Differential Revision: D41157646