Adding show/hide Native Implementation of Dev Loading Module #35746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D42258041 fbshipit-source-id: bd2498a014c49f3cbeefe8e72c14b4d0778f3d94
Summary: Reverting the LoadingView.android.js change of native implementation of DevLoadingView done in D42258041 (facebook@068a208) since it will break the existing 'Refreshing...` indicator on Mobile Android as the native implementation currently is just the skeleton with loggin, not the actual implemenation of `showMessage()` & `hide()` Differential Revision: D42284732 fbshipit-source-id: 135528e3204cbbced7f44e09f807f3aab8bdcb92
Summary: Changelog: [Android][Added] - For supporting Dev Loading View across multiple platforms, adding native implementation for showMessage() & hide() of Dev Loading Module Differential Revision: D42286425 fbshipit-source-id: d699d334391fb49403f0576867bfa907c6221f3f
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42286425 |
react-native-bot
added
Platform: Android
Base commit: 8ccb861 |
Base commit: 8ccb861 |
|
PR build artifact for db1ed51 is ready. |
|
PR build artifact for db1ed51 is ready. |
|
This pull request has been merged in 4923a09. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…k#35746) Summary: Pull Request resolved: facebook#35746 Changelog: [Android][Added] - For supporting Dev Loading View across multiple platforms, adding native implementation for showMessage() & hide() of Dev Loading Module Reviewed By: rshest Differential Revision: D42286425 fbshipit-source-id: b2aa160583bc86965501f3ed3027152bb0b47af0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Android][Added] - For supporting Dev Loading View across multiple platforms, adding native implementation for showMessage() & hide() of Dev Loading Module
Differential Revision: D42286425