Add accessibilityLanguage type
#35882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 477f546 |
NickGerleman
approved these changes
Jan 19, 2023
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@NickGerleman merged this pull request in 71c4f57. |
kelset
pushed a commit
that referenced
this pull request
Jan 30, 2023
Summary: `accessibilityLanguage` is missing from `AccessibilityPropsIOS` TypeScript interface ## Changelog [GENERAL] [FIXED] - Added missing `accessibilityLanguage` TypeScript type <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> Pull Request resolved: #35882 Test Plan: Ran `yarn test-typescript` and `yarn test-typescript-offline` and there were no errors. Reviewed By: christophpurrer Differential Revision: D42604363 Pulled By: NickGerleman fbshipit-source-id: fb8dd4b5bba78a080473a9dc7b49a07587530229
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: `accessibilityLanguage` is missing from `AccessibilityPropsIOS` TypeScript interface ## Changelog [GENERAL] [FIXED] - Added missing `accessibilityLanguage` TypeScript type <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> Pull Request resolved: facebook#35882 Test Plan: Ran `yarn test-typescript` and `yarn test-typescript-offline` and there were no errors. Reviewed By: christophpurrer Differential Revision: D42604363 Pulled By: NickGerleman fbshipit-source-id: fb8dd4b5bba78a080473a9dc7b49a07587530229
Merged
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
accessibilityLanguageis missing fromAccessibilityPropsIOSTypeScript interfaceChangelog
[GENERAL] [FIXED] - Added missing
accessibilityLanguageTypeScript typeTest Plan
Ran
yarn test-typescriptandyarn test-typescript-offlineand there were no errors.