fix(0.71-stable/tests): attempting to fix iOS template tests #35963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
hoxyq
force-pushed
the
0.71-stable-fix-verdaccio-on-ios
branch
3 times, most recently
from
8291ed1
to
8226ef6
Compare
Summary: Removing a stale configuration that was configuring username/password before publishing to NPM. This is effectively unused + the Github Token there is invalid therefore can be removed. ## Changelog [INTERNAL] - Remove unused .netrc file from CircleCI Pull Request resolved: facebook#35785 Test Plan: n/a Reviewed By: cipolleschi Differential Revision: D42385163 Pulled By: cortinico fbshipit-source-id: 0dbbf44459d59f792da4221d6100800a2f4efda2
hoxyq
force-pushed
the
0.71-stable-fix-verdaccio-on-ios
branch
10 times, most recently
from
f11ba03
to
55bba8f
Compare
Summary: Node 18: https://nodejs.org/de/blog/announcements/v18-release-announce/ Node 16 EOL: 2023-09-11 https://nodejs.org/en/blog/announcements/nodejs16-eol/ Node 18 EOL: 2025-04-30 Follow-up - facebook#34171 - facebook#32980 Ref - react-native-community/docker-android#187 cc ramonmedel cortinico gengjiawen ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [JavaScript] [Changed] - Bump node version from 16 to 18 Pull Request resolved: facebook#35443 Test Plan: Everything builds and runs as expected Reviewed By: cipolleschi Differential Revision: D41531161 Pulled By: cortinico fbshipit-source-id: 305888f55ed179f75bef34548aebf22fc2951308
hoxyq
force-pushed
the
0.71-stable-fix-verdaccio-on-ios
branch
from
55bba8f
to
9f82b9c
Compare
kelset
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently receiving weird errors on CircleCI machines for iOS, android ones work well
https://app.circleci.com/pipelines/github/facebook/react-native/19037/workflows/7987fa61-03d1-4200-910b-ebca0ec04054
Moved
echo "//localhost:4873/:_authToken=secretToken" > .npmrcbefore bootstrapping verdaccio, looks like there was a race-condition on node 16+Still don't know why this works well on
mainbranch