Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNGP - Properly set the jsRootDir default value #35992

Closed
wants to merge 1 commit into from

Commits on Jan 27, 2023

  1. RNGP - Properly set the jsRootDir default value

    Summary:
    Fixes software-mansion/react-native-gesture-handler#2382
    
    I've just realized that the default value fo `jsRootDir` is not entirely correct.
    That's the root of the folder where the codegen should run.
    
    For apps, it should be defaulted to `root` (i.e. ../../)
    For libraries, it should be defaulted to `../` (currently is root).
    
    This causes a problem where libraries without either a `codegenConfig` or a `react{ jsRootDir = ... }`
    specified in the build.gradle will be invoking the codegen and generating duplicated symbols.
    
    Changelog:
    [Android] [Fixed] - RNGP - Properly set the `jsRootDir` default value
    
    Differential Revision: D42806411
    
    fbshipit-source-id: 44371edec593aba5a5115d05e6f8d2e86ec6dc11
    cortinico authored and facebook-github-bot committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    a2555e9 View commit details
    Browse the repository at this point in the history