Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publishing-bumped-packages): look for status code instaead of stderr #36004

Closed
wants to merge 1 commit into from
Closed

fix(publishing-bumped-packages): look for status code instaead of stderr #36004

wants to merge 1 commit into from

Commits on Jan 30, 2023

  1. fix(publishing-bumped-packages): look for status code instaead of std… 

    …err (facebook#36004)

Summary:
Pull Request resolved: facebook#36004

Changelog: [Internal]

This fixes CircleCI job, which is responsible for publishing bumped packages. We should not check for `stderr`, apparently `npm` uses it to store debug information:
- npm/npm#118 (comment)

So we've tried to use this on 0.71-stable before and it succesfully published one package, but have exited right after it because `stderr` was not empty

Reviewed By: cipolleschi

Differential Revision: D42836212

fbshipit-source-id: a09cb7adc750cbb9e735bdefbe92050f9f5767c6
    @hoxyq @facebook-github-bot
    hoxyq authored and facebook-github-bot committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    8399050 View commit details
    Browse the repository at this point in the history