Enable NDEBUG in production builds #36194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This change is the iOS equivalent of D43344120 (facebook@8486e19), but for iOS. ## Changelog: [iOS][Fixed] - Turn on NDEBUG when pods are installed for production. Reviewed By: cortinico Differential Revision: D43388881 fbshipit-source-id: 21ebc403955327acbad394936aa4d98f18948a57
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D43388881 |
Base commit: 3218680 |
|
This pull request has been merged in 421df9f. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36194 This change is the iOS equivalent of D43344120 (facebook@8486e19), but for iOS. ## Changelog: [iOS][Fixed] - Turn on NDEBUG when pods are installed for production. Reviewed By: cortinico Differential Revision: D43388881 fbshipit-source-id: 5c16d3d7b4265e4ee2f265a5f992cffee30f3887
github-merge-queue bot
pushed a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Aug 9, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Related to #4901. This PR properly sets `NDEBUG` flag when building in release mode. References: * facebook/react-native#36172 * facebook/react-native#38314 * facebook/react-native#36194 ## Test plan <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change is the iOS equivalent of D43344120 (8486e19), but for iOS.
Changelog:
[iOS][Fixed] - Turn on NDEBUG when pods are installed for production.
Reviewed By: cortinico
Differential Revision: D43388881