Commits on Mar 24, 2023

1. Minimize EditText Spans 5/9: Strikethrough and Underline (facebook#36544 …

   )
   
   Summary:
   Pull Request resolved: facebook#36544
   
   This is part of a series of changes to minimize the number of spans committed to EditText, as a mitigation for platform issues on Samsung devices. See this [GitHub thread]( facebook#35936 (comment)) for greater context on the platform behavior.
   
   This change makes us apply strikethrough and underline as paint flags to the underlying EditText, instead of just the spans. We then opt ReactUnderlineSpan and ReactStrikethroughSpan into being strippable.
   
   This does actually create visual behavior changes, where child text will inherit any underline or strikethrough of the root EditText (including if the child specifies `textDecorationLine: "none"`. The new behavior is consistent with both iOS and web though, so it seems like more of a bugfix than a regression.
   
   Changelog:
   [Android][Fixed] - Minimize Spans 5/N: Strikethrough and Underline
   
   Reviewed By: rshest
   
   Differential Revision: D44240778
   
   fbshipit-source-id: 37873c919d2fc657627aa3bd07ed164e8e410c33

   

   NickGerleman authored and facebook-github-bot committed Mar 24, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 6f53ede
   • Browse repository at this point

   Copy the full SHA

   6f53ede View commit details

   Browse the repository at this point in the history