Simplify createInitialState interface #37069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45183692 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Apr 25, 2023
Summary: Pull Request resolved: facebook#37069 changelog: [internal] To create initial C++ state, nothing beside props is needed from `ShadowNodeFragment` and this diff removes it. It makes creation of state easier as we will no longer need to check if props are nullptr. Reviewed By: mdvacca Differential Revision: D45183692 fbshipit-source-id: 8ec7f4d99dc2eba13e33ef249cf248bd81cf216c
sammy-SC
force-pushed
the
export-D45183692
branch
from
24401cb to
87e8da5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45183692 |
Base commit: 5ff19f0 |
|
This pull request was exported from Phabricator. Differential Revision: D45183692 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Apr 25, 2023
Summary: Pull Request resolved: facebook#37069 changelog: [internal] To create initial C++ state, nothing beside props is needed from `ShadowNodeFragment` and this diff removes it. It makes creation of state easier as we will no longer need to check if props are nullptr. Reviewed By: mdvacca Differential Revision: D45183692 fbshipit-source-id: a2993063b6c673be2356a1524cf51d8ce6ab63ed
sammy-SC
force-pushed
the
export-D45183692
branch
from
87e8da5 to
df1da66
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45183692 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Apr 25, 2023
Summary: Pull Request resolved: facebook#37069 changelog: [internal] To create initial C++ state, nothing beside props is needed from `ShadowNodeFragment` and this diff removes it. It makes creation of state easier as we will no longer need to check if props are nullptr. Reviewed By: mdvacca Differential Revision: D45183692 fbshipit-source-id: aa03c86b6e18a7160f50e81d2afbcd8e76ea5277
sammy-SC
force-pushed
the
export-D45183692
branch
from
df1da66 to
66f3d9b
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Apr 25, 2023
Summary: Pull Request resolved: facebook#37069 changelog: [internal] To create initial C++ state, nothing beside props is needed from `ShadowNodeFragment` and this diff removes it. It makes creation of state easier as we will no longer need to check if props are nullptr. Reviewed By: mdvacca Differential Revision: D45183692 fbshipit-source-id: a5c9b76294a74553b1867ce04ac2bf24e0cd9641
sammy-SC
force-pushed
the
export-D45183692
branch
from
66f3d9b to
32d06fd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45183692 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Apr 25, 2023
Summary: Pull Request resolved: facebook#37069 changelog: [internal] To create initial C++ state, nothing beside props is needed from `ShadowNodeFragment` and this diff removes it. It makes creation of state easier as we will no longer need to check if props are nullptr. Reviewed By: mdvacca Differential Revision: D45183692 fbshipit-source-id: c7c90582fdf3eb2f874d8b0885d9d635eb02395b
sammy-SC
force-pushed
the
export-D45183692
branch
from
32d06fd to
5981353
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45183692 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45183692 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Apr 25, 2023
Summary: Pull Request resolved: facebook#37069 changelog: [internal] To create initial C++ state, nothing beside props is needed from `ShadowNodeFragment` and this diff removes it. It makes creation of state easier as we will no longer need to check if props are nullptr. Reviewed By: mdvacca Differential Revision: D45183692 fbshipit-source-id: 76dd3d2363329031ff37288b9a5a733682d3525f
sammy-SC
force-pushed
the
export-D45183692
branch
from
5981353 to
8b27ef5
Compare
Summary: Pull Request resolved: facebook#37069 changelog: [internal] To create initial C++ state, nothing beside props is needed from `ShadowNodeFragment` and this diff removes it. It makes creation of state easier as we will no longer need to check if props are nullptr. Reviewed By: mdvacca Differential Revision: D45183692 fbshipit-source-id: 658bb18992f53fa8943bd6018aa300d23fc35404
sammy-SC
force-pushed
the
export-D45183692
branch
from
8b27ef5 to
04c9bc0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45183692 |
|
This pull request has been merged in 2cda4f7. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#37069 changelog: [internal] To create initial C++ state, nothing beside props is needed from `ShadowNodeFragment` and this diff removes it. It makes creation of state easier as we will no longer need to check if props are nullptr. Reviewed By: mdvacca Differential Revision: D45183692 fbshipit-source-id: 81ab8eb3c57f6ff64aaed7c5b395555dce6b60b2
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#37069 changelog: [internal] To create initial C++ state, nothing beside props is needed from `ShadowNodeFragment` and this diff removes it. It makes creation of state easier as we will no longer need to check if props are nullptr. Reviewed By: mdvacca Differential Revision: D45183692 fbshipit-source-id: 81ab8eb3c57f6ff64aaed7c5b395555dce6b60b2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
To create initial C++ state, nothing beside props is needed from
ShadowNodeFragmentand this diff removes it.It makes creation of state easier as we will no longer need to check if props are nullptr.
Reviewed By: mdvacca
Differential Revision: D45183692