Polish DevServerHelper #37266
Closed
Polish DevServerHelper #37266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45600284 |
Base commit: 8aa2281 |
Summary:
DevServerHelper was having a constructor parameter as `DevInternalSettings` which is effectively internal. This should not be the case as that class is Internal as was bleeding out of the public API.
I've updated the primary constructor to take instead:
```
public DevServerHelper(
DeveloperSettings settings,
String packageName,
InspectorPackagerConnection.BundleStatusProvider bundleStatusProvider,
PackagerConnectionSettings packagerConnectionSettings) {
```
This is breaking change for users that were depending on the Internal class.
Changelog:
[Android] [Removed] - DevServerHelper should not depend on internal ctor parameter
Differential Revision: D45600283
fbshipit-source-id: 6cc07fed83355c1da27520cfc6ef73f9d9b03d6f
Summary: Pull Request resolved: facebook#37266 This class is full of warnings and other issues which I'm doing a pass on it since I touched it: - Missing `NonNull` annotations - Try with resources missing - Unused inner Interfaces that can be removed Technically a breaking change for users as we do have some public interfaces that have been removed, though not sure why people would depend on those. Changelog: [Android] [Removed] - Polish DevServerHelper (remove unused Interfaces) Reviewed By: motiz88 Differential Revision: D45600284 fbshipit-source-id: d0aae5ddad179a812e5b39ebbe0a3ce09b911bc8
cortinico
force-pushed
the
export-D45600284
branch
from
ba706c3 to
4087f09
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45600284 |
|
This pull request has been merged in 7dcaf00. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#37266 This class is full of warnings and other issues which I'm doing a pass on it since I touched it: - Missing `NonNull` annotations - Try with resources missing - Unused inner Interfaces that can be removed Technically a breaking change for users as we do have some public interfaces that have been removed, though not sure why people would depend on those. Changelog: [Android] [Removed] - Polish DevServerHelper (remove unused Interfaces) Reviewed By: motiz88 Differential Revision: D45600284 fbshipit-source-id: 6274ae29ff3384d7409764fd6474da68d777958a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This class is full of warnings and other issues which I'm doing a pass on it since I touched it:
NonNullannotationsTechnically a breaking change for users as we do have some public interfaces that have been removed, though not sure why people would depend on those.
Changelog:
[Android] [Removed] - Polish DevServerHelper (remove unused Interfaces)
Reviewed By: motiz88
Differential Revision: D45600284