Add a feature flag to disable [CATransaction commit] during mount #37459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45870408 |
Base commit: 6d6b1fd |
…cebook#37459) Summary: Pull Request resolved: facebook#37459 changelog: [internal] Let's try to dissable manual `[CATransaction commit]`. This may reduce UI thrash in case several Fabric transactions are committed within single UIRunLoop tick. While working on [the new architecture benchmarks](reactwg/react-native-new-architecture#123), with the help of instrumentation I noticed two paints on some occasions. This was happening around 50% of the time I executed a scenario. It dropped the rendering time on 5k of <Text /> from ~800ms down to ~600ms. Also, the original reason why `[CATransaction commit]` was added has passed. It was added to make Screenshot tests less flaky but we no longer use screenshot tests. Reviewed By: javache Differential Revision: D45870408 fbshipit-source-id: db4ea823800a4640ade09caf3d2078f052ec4aaf
|
This pull request was exported from Phabricator. Differential Revision: D45870408 |
sammy-SC
force-pushed
the
export-D45870408
branch
from
9c65d32
to
71e7201
Compare
|
This pull request has been merged in 0a4a95f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
Let's try to dissable manual
[CATransaction commit]. This may reduce UI thrash in case several Fabric transactions are committed within single UIRunLoop tick.While working on the new architecture benchmarks, with the help of instrumentation I noticed two paints on some occasions. This was happening around 50% of the time I executed a scenario. It dropped the rendering time on 5k of from ~800ms down to ~600ms.
Also, the original reason why
[CATransaction commit]was added has passed. It was added to make Screenshot tests less flaky but we no longer use screenshot tests.Reviewed By: javache
Differential Revision: D45870408