Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Actions] Bump autorebase.yml to v1.8 #37584

Closed
wants to merge 2 commits into from
Closed

[Actions] Bump autorebase.yml to v1.8 #37584

wants to merge 2 commits into from

Conversation

Pranav-yadav
Copy link
Contributor

Summary:

cirrus-actions/rebase v.1.8 fixes number of bugs.
v1.8 Changelog: https://github.com/cirrus-actions/rebase/releases/tag/1.8
See: https://github.com/cirrus-actions/rebase

Changelog:

[GENERAL] [SECURITY] - [Actions] Bump autorebase.yml to v1.8

Test Plan:

  • /rebase comment should rebase the PR as usual.

@analysis-bot
Copy link

analysis-bot commented May 26, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,739,890 -4,719
android hermes armeabi-v7a 8,051,056 -5,190
android hermes x86 9,230,203 -5,207
android hermes x86_64 9,081,578 -4,709
android jsc arm64-v8a 9,302,500 -4,804
android jsc armeabi-v7a 8,491,267 -5,271
android jsc x86 9,363,884 -5,302
android jsc x86_64 9,619,372 -4,808

Base commit: 0e83c53
Branch: main

@Pranav-yadav
Copy link
Contributor Author

Pranav-yadav commented May 26, 2023 •
edited
Loading

Idk why CLA check is waiting, for 3hrs... 🤔

Cc: @cipolleschi

@Pranav-yadav
Copy link
Contributor Author

Pranav-yadav commented May 26, 2023 •
edited
Loading

Note: I'll be taking a break, since finished with exams and haven't taken one in a while 😅.
I've "Allowed edits by maintainers". So, please feel free to suggest and commit changes as you feel right.
Thanks for reviewing and providing feedback

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 26, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cortinico
cortinico reviewed May 30, 2023
View reviewed changes
.github/workflows/autorebase.yml Outdated
steps:
- name: Checkout the latest code
uses: actions/checkout@v3
with:
token: ${{ secrets.GITHUB_TOKEN }}
token: ${{ secrets.GITHUB_TOKEN }} # TODO: consider using a PAT with required permissions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need those TODOs? We actually want to use built-in GitHub Action's CI

Copy link
Contributor Author

@Pranav-yadav Pranav-yadav May 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I was unsure, which permissions are allowed/set for the token, and as PATs are always better than the default token because of the more fine-grained control they provide us hence, added that comment.

But, as we can see the defaults set/allowed permission here (e.g.): https://github.com/facebook/react-native/actions/runs/5053438769/jobs/9067284908#step:1:16

So, no worries. Removing Removed the comments...

Ref: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token

@Pranav-yadav Pranav-yadav requested a review from cortinico May 31, 2023 09:04
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 7, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in e944bd7.

adamaveray added a commit to adamaveray/react-native that referenced this pull request Jun 8, 2023
@adamaveray
Merge branch 'main' into feature/automaticKeyboardInsetsImprovements
7422c3c 
* main: (1824 commits)
  Convert FallbackJSBundleLoaderTest to Kotlin (facebook#37750)
  Migrate JSPackagerClientTest to Kotlin (facebook#37747)
  (refactor): kotlin-ify `ShareModuleTest.java` (facebook#37746)
  Upgrade `@react-native/codegen-typescript-test`'s Jest dependency to Jest 29 (facebook#37745)
  Move flow-typed definitions to repo root (facebook#37636)
  Convert InterpolatorTypeTest to Kotlin (facebook#37724)
  Update documentation of ReactHost.reload method (facebook#37691)
  Reduce visibility of ReactHost.destroy() method (facebook#37693)
  Reduce visibility in React Context (facebook#37695)
  Remove InstanceHandleHelper as unused (facebook#37740)
  Convert CompositeReactPackageTest to Kotlin (facebook#37734)
  Add license header to SetSpanOperation.java
  Convert FakeEventDispatcher to kotlin (facebook#37739)
  Convert FakeRCTEventEmitter to Kotlin (facebook#37733)
  Convert InteropModuleRegistryTest to Kotlin (facebook#37735)
  Bump `autorebase.yml` to `v1.8` (facebook#37584)
  Convert StackTraceHelperTest to Kotlin (facebook#37741)
  Convert BlobModuleTest class to Kotlin (facebook#37719)
  Update prettier to v2.8.8 (facebook#37738)
  Introduce BoltsFutureTask class to avoid leaking bolts.Task into ReactHost API (facebook#37744)
  ...

# Conflicts:
#	BUCK
#	packages/react-native/React/Views/UIResponder+FirstResponder.h
#	packages/react-native/React/Views/UIResponder+FirstResponder.m
@Pranav-yadav Pranav-yadav deleted the @Pranav-yadav/bump-autorebase-1.8 branch June 8, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico Awaiting requested review from cortinico

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pranav-yadav @analysis-bot @facebook-github-bot @cortinico