Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grouping of console logs #37835

Closed
wants to merge 1 commit into from
Closed

Fix grouping of console logs #37835

wants to merge 1 commit into from

Conversation

mattbfb
Copy link
Contributor

@mattbfb mattbfb commented Jun 12, 2023

Summary:
Chrome Dev Tools doesn't correctly display grouped console logs (i.e. console output between a console.group and console.groupEnd) when timestamps are all zero.

Populate the timestamp field so grouping functions as expected.

Differential Revision: D46605659

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jun 12, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46605659

@analysis-bot
Copy link

analysis-bot commented Jun 12, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,042,649 -40
android hermes armeabi-v7a 8,292,334 -152
android hermes x86 9,559,284 -8
android hermes x86_64 9,401,374 +12
android jsc arm64-v8a 9,601,860 +6
android jsc armeabi-v7a 8,728,988 +6
android jsc x86 9,689,350 +5
android jsc x86_64 9,935,421 +6

Base commit: a28881a
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46605659

4 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46605659

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46605659

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46605659

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46605659

@facebook-github-bot
Fix grouping of console logs (#37835)
4c260d2 
Summary:
Pull Request resolved: #37835

Chrome Dev Tools doesn't correctly display grouped console logs (i.e. console output between a `console.group` and `console.groupEnd`) when timestamps are all zero.

Populate the timestamp field so grouping functions as expected.

Changelog: [General] [Fixed] Fix timestamps and grouped display of console messages within in a `console.group`

Reviewed By: fbmal7

Differential Revision: D46605659

fbshipit-source-id: 356545052068fb1a6b82d48665f48b98dab3cf3e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46605659

@github-actions
Copy link

This pull request was successfully merged by Matt Blagden in 48791bc.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Jun 27, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 48791bc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattbfb @facebook-github-bot @analysis-bot