Localize Talkback strings #37856
Closed
Localize Talkback strings #37856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46692127 |
Summary: Pull Request resolved: facebook#37856 These strings are spoken to the user when using an ascessibility role or state not natively supported by Talkback. We can enable these for translation by removing flags to disable localization, and adding descriptions to each string. These are derived from MDN for ARIA (used for iOS strings), along with Android and iOS documentation. Note that this was explicitly disabled as part of D15087192 because of creating spam which was hitting the GitHub repo, but when translation was enabled for the dev menu, this ended up being a non-issue after initial translation. And we really do want these to be localized. Changelog: [Android][Fixed] - Localize Talkback strings Reviewed By: cortinico Differential Revision: D46692127 fbshipit-source-id: 052791d1e5aa2def6529357860d9db6904351be3
NickGerleman
force-pushed
the
export-D46692127
branch
from
ee9416b to
084cbcc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46692127 |
|
This pull request has been merged in a7e5c96. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These strings are spoken to the user when using an ascessibility role or state not natively supported by Talkback.
We can enable these for translation by removing flags to disable localization, and adding descriptions to each string. These are derived from MDN for ARIA (used for iOS strings), along with Android and iOS documentation.
Note that this was explicitly disabled as part of D15087192 because of creating spam which was hitting the GitHub repo, but when translation was enabled for the dev menu, this ended up being a non-issue after initial translation. And we really do want these to be localized.
Changelog:
[Android][Fixed] - Localize Talkback strings
Differential Revision: D46692127