Refactor integration of BridgelessReactPackage into ReactHost #38010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46410795 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jun 21, 2023
…ok#38010) Summary: Pull Request resolved: facebook#38010 This diff refactors the integration of ReactPackages into ReactHost and ReactHostDelegate. As part of this diff I'm also modifying ReactHostDelegate to depend on TurboModuleManagerDelegate.Builder instead of TurboModuleManagerDelegateBuilder. This is necessary to be able to create BridgelessReactPackage inside ReactInstance bypass-github-export-checks changelog: [internal] internal Reviewed By: luluwu2032 Differential Revision: D46410795 fbshipit-source-id: b8ad5bb042fcb296c2720bfb031086cecc685997
mdvacca
force-pushed
the
export-D46410795
branch
from
b563820 to
b21d43a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46410795 |
Base commit: 7920ae8 |
|
This pull request was exported from Phabricator. Differential Revision: D46410795 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jun 22, 2023
…ok#38010) Summary: Pull Request resolved: facebook#38010 This diff refactors the integration of ReactPackages into ReactHost and ReactHostDelegate. As part of this diff I'm also modifying ReactHostDelegate to depend on TurboModuleManagerDelegate.Builder instead of TurboModuleManagerDelegateBuilder. This is necessary to be able to create BridgelessReactPackage inside ReactInstance bypass-github-export-checks changelog: [internal] internal Reviewed By: luluwu2032 Differential Revision: D46410795 fbshipit-source-id: 6f7025da7b4e406bbe87ed7a71d2a7f02f168140
mdvacca
force-pushed
the
export-D46410795
branch
from
b21d43a to
fa55c43
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46410795 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jun 22, 2023
…ok#38010) Summary: Pull Request resolved: facebook#38010 This diff refactors the integration of ReactPackages into ReactHost and ReactHostDelegate. As part of this diff I'm also modifying ReactHostDelegate to depend on TurboModuleManagerDelegate.Builder instead of TurboModuleManagerDelegateBuilder. This is necessary to be able to create BridgelessReactPackage inside ReactInstance bypass-github-export-checks changelog: [internal] internal Reviewed By: luluwu2032 Differential Revision: D46410795 fbshipit-source-id: a94a62c50c67e091942f99705a828e79d2cb326c
mdvacca
force-pushed
the
export-D46410795
branch
from
fa55c43 to
7c3d97f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46410795 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jun 22, 2023
…ok#38010) Summary: Pull Request resolved: facebook#38010 This diff refactors the integration of ReactPackages into ReactHost and ReactHostDelegate. As part of this diff I'm also modifying ReactHostDelegate to depend on TurboModuleManagerDelegate.Builder instead of TurboModuleManagerDelegateBuilder. This is necessary to be able to create BridgelessReactPackage inside ReactInstance bypass-github-export-checks changelog: [internal] internal Reviewed By: luluwu2032 Differential Revision: D46410795 fbshipit-source-id: 7a4e32110d1eae6e6098c9dc1ebcc2afcd556a39
mdvacca
force-pushed
the
export-D46410795
branch
from
7c3d97f to
b451254
Compare
Summary: Move BridgelessReactPackage to com.facebook.react package. This is necessary because BridgelessReactPackage is a core package that needs to be part of RN (and should not be re-defined by all apps) I will revisit naming in a later diff changelog: [internal] internal Differential Revision: D46918732 fbshipit-source-id: 96adabdec3017f54fc55091b2e622a3b71255790
…ok#38010) Summary: Pull Request resolved: facebook#38010 This diff refactors the integration of ReactPackages into ReactHost and ReactHostDelegate. As part of this diff I'm also modifying ReactHostDelegate to depend on TurboModuleManagerDelegate.Builder instead of TurboModuleManagerDelegateBuilder. This is necessary to be able to create BridgelessReactPackage inside ReactInstance bypass-github-export-checks changelog: [internal] internal Reviewed By: luluwu2032 Differential Revision: D46410795 fbshipit-source-id: c2bb99946cb3719ed891f7a67e4c979896adc15b
|
This pull request was exported from Phabricator. Differential Revision: D46410795 |
mdvacca
force-pushed
the
export-D46410795
branch
from
b451254 to
524cf67
Compare
|
This pull request has been merged in 74e6c95. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff refactors the integration of ReactPackages into ReactHost and ReactHostDelegate.
As part of this diff I'm also modifying ReactHostDelegate to depend on TurboModuleManagerDelegate.Builder instead of TurboModuleManagerDelegateBuilder. This is necessary to be able to create BridgelessReactPackage inside ReactInstance
bypass-github-export-checks
changelog: [internal] internal
Reviewed By: luluwu2032
Differential Revision: D46410795