Remove testID from TextStyle types #38053
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
testID
which is a valid prop for<Text>
is also found in the types forTextStyle
. This pull request removes said property from the styles.Changelog:
[General] [Fixed] - Remove testID from TextStyle types
Test Plan:
TextStyle
is used to type theStyleSheet
along withViewStyle
andImageStyle
which do not containtestID
.testID
is used to identify components with the mentioned prop. This works forText
and will continue to do so,TextProps
hastestID
added specifically. When usinggetByTestId
in jest adding testID to the style already has no effect.When adding
testID
to a style a warning will already be shown in development: Warning: Failed prop type: Invalid props.style keytestID
supplied toText
.